From 2f4ea3d52ac78932ae0dbe9a3e06bf0a2e8a9045 Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Wed, 4 Nov 2026 20:47:09 +0100 Subject: [PATCH] fix: mng-0479 IT fix Added a slight change, that makes IT pass with Maven 3.10.0 and 3.10.1+, basically by introducing "alt central" as second repository. The new repository does not affect redefinition of "central" that is also asserted. --- ...MavenITmng0479OverrideCentralRepoTest.java | 10 +++++++ .../mng-0479/test/settings-template.xml | 26 +++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0479OverrideCentralRepoTest.java b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0479OverrideCentralRepoTest.java index 256c9c4ad..30cfb64f6 100644 --- a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0479OverrideCentralRepoTest.java +++ b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0479OverrideCentralRepoTest.java @@ -46,6 +46,16 @@ public MavenITmng0479OverrideCentralRepoTest() { public void testitModel() throws Exception { File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-0479"); + // Note: starting with Resolver 2.0.25 that contains this fix https://github.com/apache/maven-resolver/pull/2192 + // this IT as is, pass-ok with 3.10.0, but it fails with 3.10.1 (Resolver 2.0.25) due that pull request above. + // The fix in PR pulls out all repositories for consideration, as central is redefined as snapshot repository! + // Hence, added a fix that works for both, 3.10.0 and 3.10.1+: added second "alt central" that points to real + // Central, as after PR 2192, there is no more "way" to trick Maven, it is now strict. + // + // History: This IT is for MNG-479, but later was "refurbished" for MNG-4769, where the override of Central + // to "snapshot only" was added (and relevant assertions). Hence, the workaround above, as it leave all + // those things in place, but also makes IT pass with 3.10.1+ + // Phase 1: Ensure the test plugin is downloaded before the test cuts off access to central File child1 = new File(testDir, "setup"); Verifier verifier = newVerifier(child1.getAbsolutePath()); diff --git a/core-it-suite/src/test/resources/mng-0479/test/settings-template.xml b/core-it-suite/src/test/resources/mng-0479/test/settings-template.xml index 85ab21eb2..5bc3bc038 100644 --- a/core-it-suite/src/test/resources/mng-0479/test/settings-template.xml +++ b/core-it-suite/src/test/resources/mng-0479/test/settings-template.xml @@ -45,6 +45,19 @@ under the License. never + + alt-central + alt-central-mng-0479 + https://repo1.maven.org/maven2 + + true + fail + never + + + false + + @@ -62,6 +75,19 @@ under the License. never + + alt-central + alt-central-mng-0479 + https://repo1.maven.org/maven2 + + true + fail + never + + + false + +