Skip to content

[Bug] Pinch on maps has too high scale factor, thus feeling unnatural #18113

Description

@mephinet

Version

5.4.1

Link to Minimal Reproduction

https://echarts.apache.org/examples/en/editor.html?c=map-usa

Steps to Reproduce

Open https://echarts.apache.org/examples/en/editor.html?c=map-usa on a smartphone. Use your fingers to pinch into the map.

Current Behavior

The zooming does not feel natural, because the scale factor is too high. E.g., when the fingers move by 1 cm, the map below the fingers moves by 3 cm.

Expected Behavior

When moving the fingers, the location of the map below each finger should stay fixed while the fingers move.

Environment

- OS: Android 12
- Browser: Chromium, Brave

Any additional comments?

I couldn't find the initial commit that started providing this hard-coded value, but maybe @100pah, who did a lot of work on the RoamController, can comment on why the calculated pinchScale is ignored and hard-coded to 1.1...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions