Skip to content

[Python] Check write_table options are accepted by dataset writer #51220

Description

@tadeja

Describe the enhancement requested

Some ParquetWriter options accepted by pq.write_table are not registered in ParquetFileWriteOptions, so pq.write_to_dataset and ds.write_dataset reject them:

pq.write_to_dataset(table, path, bloom_filter_options={'a': True})

Output

  File "_/python/pyarrow/parquet/core.py", line 2279, in write_to_dataset
    write_options = parquet_format.make_write_options(**kwargs)
pyarrow._dataset_parquet.ParquetFileFormat.make_write_options
    (<ParquetFileWriteOptions> opts).update(**kwargs)
  File "pyarrow/_dataset_parquet.pyx", line 628, in pyarrow._dataset_parquet.ParquetFileWriteOptions.update
    raise TypeError("unexpected parquet write option: " + name)
TypeError: unexpected parquet write option: bloom_filter_options

Similar to use_content_defined_chunking getting added in #47499 / #47498

implementor's note

A test that every option in inspect.signature(pq.write_table).parameters is accepted by ParquetFileFormat.make_write_options may be considered to prevent this in the future.

Component(s)

Python

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions