Commit fdec80a
committed
[C++][Parquet] Correct three comments on the DELTA_BINARY_PACKED scan
The coalescing guard is against values_remaining_current_mini_block_, so
what it needs room for is the rest of the current miniblock, not a whole
one; a run legitimately starts from a partly consumed miniblock.
"Four is the narrowest width measured to win" reused a word that means
bit width everywhere else in this file. The threshold is four lanes.
PrefixSumVectorAndTail claimed its deltas pin the stored width at every
step of its loop. At the top of the range the spread is all ones, which
as a signed delta is -1, so the frame absorbs it and the miniblock
stores width 1. Every stored width from 0 to the type's width is still
reached, so the coverage is unchanged; only the comment was wrong.
Comments only.1 parent 4c8423d commit fdec80a
2 files changed
Lines changed: 10 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1471 | 1471 | | |
1472 | 1472 | | |
1473 | 1473 | | |
1474 | | - | |
1475 | | - | |
1476 | | - | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
1477 | 1477 | | |
1478 | 1478 | | |
1479 | 1479 | | |
| |||
1684 | 1684 | | |
1685 | 1685 | | |
1686 | 1686 | | |
1687 | | - | |
| 1687 | + | |
1688 | 1688 | | |
1689 | 1689 | | |
1690 | 1690 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2118 | 2118 | | |
2119 | 2119 | | |
2120 | 2120 | | |
2121 | | - | |
| 2121 | + | |
2122 | 2122 | | |
2123 | 2123 | | |
2124 | 2124 | | |
2125 | 2125 | | |
2126 | 2126 | | |
2127 | | - | |
2128 | | - | |
2129 | | - | |
2130 | | - | |
| 2127 | + | |
| 2128 | + | |
| 2129 | + | |
| 2130 | + | |
| 2131 | + | |
2131 | 2132 | | |
2132 | 2133 | | |
2133 | 2134 | | |
| |||
0 commit comments