Improvements suggestions

[swiaam]

Hi @delirius325,

First of all, thanks for sharing this plugin, really neat and useful.
May I suggest a few improvements?

• I think it's better not to ship empty values to ES, it's unnecessary overhead and payload and often leads to warnings in Kibana; I've seen this mainly with AssertionResults and FailureMessage so far, but it's likely to happen in other use-cases as well
• Introduce an option to enable/disable sending RequestBody and ResponseBody regardless of es.test.mode
• I didn't get the chance to check this one yet, but would be cool if es.parse.all.req.headers=true and es.parse.all.res.headers=true would still work in all es.test.mode
• In Filters, introduce an option to exclude and not only include
• Not all fields are documented, would be nice to have them all well explained

Besides that and the other issue I raised, it looks great!

Thanks again.

Cheers.

[anthonygauthier]

Hi @swiaam,

1. I'll look into this, I haven't used Kibana heavily with my plugin. I've mostly used Grafana, so I'm not aware of errors regarding Kibana. It'd be really appreciated if you could make a PR regarding this.
2. We'll have to look into a way of doing this gracefully, I don't want to add too many options and clutter the listener's configuration GUI.
3. Again, sort of refers to your previous request. The whole point of es.test.mode is to silence certain fields and alleviate payloads (according to use-case).
4. RegExp are supported in filters, so it's possible to do pretty much anything. Although, it'd be possible to add an exclude pattern (i.e !!!doNotIncludeThisString).
5. Fair point, the documentation has been lacking lately.

Thanks a lot 😄 !

[premkumarjcts]

Hello sir - how good elastic search is when compared to influx when it comes to handling heavy load of 10000 tps or so from jmeter? Could you please share some benchmarks.

[anthonygauthier]

I don't have any benchmark and I personally don't use the influx backend listener. But I've never encountered any issues in terms of performance overhead coming from the ES backend listener. If anything, you can set the es.bulk.size option to your liking to avoid making too many HTTP requests to your ES instance.