Give Up first-come kicks co-maint

[thibaultduponchelle]

Put Up My Distribution(s) For Adoption is kicking co-maint

When using Put Up My Distribution(s) For Adoption with one first-come USER and a co-maint OTHER:

• ADOPTME becomes first-come
• USER becomes co-maint
• OTHER is kicked from co-maint

According to me, USER should be added to co-maint along OTHER

@charsbar Can you confirm this behaviour and what is the intended behaviour?

[neilb]

I just tested this, and it worked as expected: I gave co-maint to someone on one of my dists, then gave that distribution up for adoption. ADOPTME had first-come, I now had co-maint, as did the person I'd previously given co-maint to.

It may be that there's a path which results in the behaviour you experienced, and another one for me.

Are you able to remember the specifics of your distribution, and exactly what you did?

To be clear: the behaviour I experienced is what's expected :-)

[thibaultduponchelle]

pause-give-up-kicks-comaint.webm

^ @neilb I recorded my "path". Do you have a different behaviour?

[thibaultduponchelle]

About the specifics of the environment:

• Using a "local" PAUSE ("path" not verified on production PAUSE)
• With a few commits late compared to production PAUSE

[neilb]

I did it on live PAUSE, with an existing distribution. I gave co-maint to OALDERS, then gave up my first-come, which resulted in ADOPTME having first-come and OALDERS and NEILB had co-maint.

My first theory is that when you upload your release, you're being given first-come (inserted into primeur), but you should also be inserted into the co-maint table (is that perms, my memory is hazy?). I wonder if you're not being added to perms and as a result when you give up your first-come it causes problems. Would that be easy for you to check, re-running your scenario, and after uploading the dist, checking the two permissions tables?

[thibaultduponchelle]

It's only a UI glitch.

Upload Acme::Tib with USER

primeur:

+-----------+------------+--------+
| package   | lc_package | userid |
+-----------+------------+--------+
| Acme::Tib | acme::tib  | USER   |
+-----------+------------+--------+

perms:

+--------+-----------+------------+--------+
| c      | package   | lc_package | userid |
+--------+-----------+------------+--------+
| 295238 | Acme::Tib | acme::tib  | USER   |
+--------+-----------+------------+--------+

packages:

+-----------+------------+---------+--------------------------------+----------+-------------------------------+------------+------------+---------+--------+
| package   | lc_package | version | dist                           | distname | file                          | filemtime  | pause_reg  | comment | status |
+-----------+------------+---------+--------------------------------+----------+-------------------------------+------------+------------+---------+--------+
| Acme::Tib | acme::tib  | 0.01    | U/US/USER/Acme-Tib-0.01.tar.gz | Acme-Tib | Acme-Tib-0.01/lib/Acme/Tib.pm | 1732520396 | 1752241111 |         | index  |
+-----------+------------+---------+--------------------------------+----------+-------------------------------+------------+------------+---------+--------+

Add OTHER as COMAINT of Acme::Tib

perms:

+--------+-----------+------------+--------+
| c      | package   | lc_package | userid |
+--------+-----------+------------+--------+
| 295238 | Acme::Tib | acme::tib  | USER   |
| 295239 | Acme::Tib | acme::tib  | OTHER  |
+--------+-----------+------------+--------+

Put Up My Distribution(s) For Adoption

primeur:

+-----------+------------+---------+
| package   | lc_package | userid  |
+-----------+------------+---------+
| Acme::Tib | acme::tib  | ADOPTME |
+-----------+------------+---------+

perms:

+--------+-----------+------------+---------+
| c      | package   | lc_package | userid  |
+--------+-----------+------------+---------+
| 295242 | Acme::Tib | acme::tib  | USER    |
| 295243 | Acme::Tib | acme::tib  | OTHER   |
+--------+-----------+------------+---------+

(OTHER was not kicked)

Upload new version of Acme::Tib (0.02) as COMAINT

packages:

+-----------+------------+---------+--------------------------------+----------+-------------------------------+------------+------------+---------+--------+
| package   | lc_package | version | dist                           | distname | file                          | filemtime  | pause_reg  | comment | status |
+-----------+------------+---------+--------------------------------+----------+-------------------------------+------------+------------+---------+--------+
| Acme::Tib | acme::tib  | 0.02    | U/US/USER/Acme-Tib-0.02.tar.gz | Acme-Tib | Acme-Tib-0.02/lib/Acme/Tib.pm | 1752241693 | 1752241795 |         | index  |
+-----------+------------+---------+--------------------------------+----------+-------------------------------+------------+------------+---------+--------+

perms:

+--------+-----------+------------+---------+
| c      | package   | lc_package | userid  |
+--------+-----------+------------+---------+
| 295245 | Acme::Tib | acme::tib  | ADOPTME |
| 295246 | Acme::Tib | acme::tib  | USER    |
| 295247 | Acme::Tib | acme::tib  | OTHER   |
+--------+-----------+------------+---------+

(perms was updated with ADOPTME)

Conclusion

It's only a matter of UI.

Interesting enough, I noticed that each user sees now different permissions (in respective ?ACTION=peek_dist_perms):

USER sees: ADOPTME - USER
OTHER sees: ADOPTME - OTHER

[thibaultduponchelle]

Searching by distribution name (listbox) is showing correct COMAINT informations though. Only "of an author" search is showing partial COMAINTs.

[thibaultduponchelle]

The culprit is the SQL select:

SELECT packages.distname,  
GROUP_CONCAT(DISTINCT primeur.userid ORDER BY primeur.userid), 
GROUP_CONCAT(DISTINCT perms.userid ORDER BY perms.userid) 
FROM packages 
LEFT JOIN primeur ON primeur.package=packages.package  
LEFT JOIN perms ON perms.package=packages.package 
AND primeur.userid <> perms.userid 
WHERE primeur.userid='USER' OR perms.userid='USER' 
GROUP BY packages.distname;

Producing:

+----------+---------------------------------------------------------------+-----------------------------------------------------------+
| distname | GROUP_CONCAT(DISTINCT primeur.userid ORDER BY primeur.userid) | GROUP_CONCAT(DISTINCT perms.userid ORDER BY perms.userid) |
+----------+---------------------------------------------------------------+-----------------------------------------------------------+
| Acme-Tib | ADOPTME                                                       | USER                                                      |
+----------+---------------------------------------------------------------+-----------------------------------------------------------+

In particular it's when adding the WHERE primeur.userid=? OR perms.userid=? GROUP BY packages.distname because of the author search via pause99_peek_dist_perms_by=a

Sounds like the GROUP BY with WHERE and LEFT JOIN is not producing the expected results later in GROUP_CONCAT.

@charsbar Do you have an idea how to fix that?