It seems like if a perms.userid is not written in uppercase, the packages are not indexed

[andk]

Neil reported that in 06perms.txt he found 5 lines with the userid 'dyacob' instead of 'DYACOB' and that these five packages where not indexed. As a quick stopgap solution I did just this:

MariaDB [mod]> update perms set userid='DYACOB' where BINARY userid='dyacob';
Query OK, 5 rows affected (1.713 sec)
Rows matched: 5  Changed: 5  Warnings: 0

I think this needs further evaluation how to prevent this from happening.

[neilb]

DYCAOB has the following in his META.json:

   "x_authority" : "cpan:dyacob",

That's not the culprit, is it? Is that not being handled case insensitively?

[charsbar]

A test like this passes without modifying lib/PAUSE/packages.pm.

diff --git a/t/mldistwatch-misc.t b/t/mldistwatch-misc.t
index f313d37..89a94fa 100644
--- a/t/mldistwatch-misc.t
+++ b/t/mldistwatch-misc.t
@@ -12,6 +12,39 @@ use Process::Status;

 use Test::More;

+subtest "meta has x_authority with lowercased id" => sub {
+  my $pause = PAUSE::TestPAUSE->init_new;
+  $pause->upload_author_fake(DYACOB => {
+    name => 'Regexp-Ethiopic',
+    version => 0.21,
+    packages => [
+      'Regexp::Ethiopic'           => { in_file => 'lib/Regexp/Ethiopic.pm' },
+      'Regexp::Ethiopic::Amharic'  => { in_file => 'lib/Regexp/Ethiopic/Amharic.pm' },
+      'Regexp::Ethiopic::Geez'     => { in_file => 'lib/Regexp/Ethiopic/Geez.pm' },
+      'Regexp::Ethiopic::Tigrigna' => { in_file => 'lib/Regexp/Ethiopic/Tigrigna.pm' },
+    ],
+    x_authority => 'cpan:dyacob',
+  });
+
+  {
+    my $result = $pause->test_reindex;
+    $result->assert_index_updated;
+
+    $result->email_ok([
+      { subject => 'PAUSE indexer report DYACOB/Regexp-Ethiopic-0.21.tar.gz' },
+    ]);
+
+    $result->package_list_ok([
+      { package => 'Regexp::Ethiopic',           version => '0.21'  },
+      { package => 'Regexp::Ethiopic::Amharic',  version => '0.21'  },
+      { package => 'Regexp::Ethiopic::Geez',     version => '0.21'  },
+      { package => 'Regexp::Ethiopic::Tigrigna', version => '0.21'  },
+    ]);
+  }
+};
+
+done_testing;exit;
+

If x_authority is the culprit, maybe we can apply a patch like this, but I'm not sure if we really need it:

diff --git a/lib/PAUSE/package.pm b/lib/PAUSE/package.pm
index fa584c7..789629e 100644
--- a/lib/PAUSE/package.pm
+++ b/lib/PAUSE/package.pm
@@ -827,7 +827,7 @@ sub checkin_into_primeur {

   Carp::confess("no userid!?") unless defined $userid;

-  my $plan = $self->hub->permissions->plan_set_first_come($userid, $package);
+  my $plan = $self->hub->permissions->plan_set_first_come(uc $userid, $package);
   $plan->();

   return 1;