From 907f24ea8eadc78160b9940ba4560047673d2ede Mon Sep 17 00:00:00 2001 From: San Date: Tue, 17 Nov 2026 13:05:45 -0800 Subject: [PATCH] ci: run the engines check's npx outside the checkout After `pnpm install`, a semver in node_modules (a transitive one, with no root bin link) shadows the package npx would fetch, and the step fails with "semver: not found". This repo has no semver in its tree today, so the check passes, but the first dependency that brings one would break it (it did in agentchat-mcp). The range is read in the checkout and npx runs in $RUNNER_TEMP. --- .github/workflows/ci.yml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f765eb0..3a56f38 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,9 +26,13 @@ jobs: with: node-version: 22 cache: pnpm + # npx runs outside the checkout: a semver already in node_modules + # (without a root bin link) would shadow the one it fetches. - name: engines.node admits Node 22 shell: bash - run: npx -y semver@7.7.4 -r "$(node -p 'require("./package.json").engines.node')" "$(node -v)" + run: | + range="$(node -p 'require("./package.json").engines.node')" + cd "$RUNNER_TEMP" && npx -y semver@7.7.4 -r "$range" "$(node -v)" - run: pnpm install --frozen-lockfile - run: pnpm type-check - run: pnpm build @@ -55,7 +59,9 @@ jobs: node-version: 24 - name: engines.node admits Node 24 shell: bash - run: npx -y semver@7.7.4 -r "$(node -p 'require("./package.json").engines.node')" "$(node -v)" + run: | + range="$(node -p 'require("./package.json").engines.node')" + cd "$RUNNER_TEMP" && npx -y semver@7.7.4 -r "$range" "$(node -v)" - name: install on Node 24 run: pnpm install --frozen-lockfile - name: build on Node 24 @@ -71,7 +77,9 @@ jobs: node-version: 26 - name: engines.node admits Node 26 shell: bash - run: npx -y semver@7.7.4 -r "$(node -p 'require("./package.json").engines.node')" "$(node -v)" + run: | + range="$(node -p 'require("./package.json").engines.node')" + cd "$RUNNER_TEMP" && npx -y semver@7.7.4 -r "$range" "$(node -v)" - name: install on Node 26 run: pnpm install --frozen-lockfile - name: build on Node 26