diff --git a/Cargo.lock b/Cargo.lock index 7579945..42f8f4d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5,7 +5,7 @@ version = 4 [[package]] name = "agent-ix-semantic-schema" version = "0.3.0" -source = "git+https://github.com/agent-ix/filament-core-data?branch=main#d7a9b7b60527b9640001acfb6fc8fdb5a9875a8f" +source = "git+https://github.com/agent-ix/filament-core-data?branch=main#327a49ca9d7ab2c12269a8db65b75f1331e165bd" [[package]] name = "ahash" diff --git a/reviews/SR-20261113192641-ver-75-pr207-code-review.md b/reviews/SR-20261113192641-ver-75-pr207-code-review.md new file mode 100644 index 0000000..66b4350 --- /dev/null +++ b/reviews/SR-20261113192641-ver-75-pr207-code-review.md @@ -0,0 +1,52 @@ +--- +id: SR-20261113192641 +title: "VER-75 quire-cli PR207 code review" +type: SpecReview +analysis: code-review +scope: "agent-ix/quire-cli; PR #207 src/commands/trace.rs, src/commands/coverage.rs, src/commands/symbols.rs, tests/cli_trace.rs, spec/functional/FR-045-trace-formalizes-output.md, spec/functional/index.md, Cargo.lock" +review_set: subset +--- + +## Summary + +Ticket: VER-75. Code review with the Rust lane folded in, over the PR diff. Tests, formatting, Clippy, and cargo-deny checks passed. One medium compatibility defect remains: the new empty `formalizes` vector is serialized into every trace JSON response, contrary to the ticket's no-marker byte-preservation acceptance criterion. + +## Findings + +| ID | Severity | Summary | Refs | +| --- | --- | --- | --- | +| FND-001 | medium | `ClaimsSection.formalizes` is serialized even when empty, so a project with no formalizes relation gets a new `claims.formalizes: []` key in every `quire trace --json` result. VER-75 acceptance criterion 10 requires byte-identical output when the module declares no formalizes marker. Skip the empty field (or otherwise preserve the prior payload) and add a regression test for that case. | src/commands/trace.rs:224-228 | + +## Examined scope + +```yaml +scope: + - {id: FR-045-AC-1, path: spec/functional/FR-045-trace-formalizes-output.md, role: examined, excerpt: "`quire trace --id --json` over a scope with a QSL `formalizes` marker lists the declaration under `claims.formalizes` only, with `claims.verifies` and `claims.implements` empty and `resolved` true."} + - {id: FR-045-AC-2, path: spec/functional/FR-045-trace-formalizes-output.md, role: examined, excerpt: "`quire trace --file --json` lists each declaration in the file under `claims.formalizes` with its resolved id."} + - {id: FR-045-AC-3, path: spec/functional/FR-045-trace-formalizes-output.md, role: examined, excerpt: "An id the corpus does not define appears in neither `quire trace` nor `quire symbols --json` output."} + - {id: FR-045-AC-4, path: spec/functional/FR-045-trace-formalizes-output.md, role: examined, excerpt: "`quire trace --format tsv` emits one `formalizes` record per relation."} + - {id: FR-045-AC-5, path: spec/functional/FR-045-trace-formalizes-output.md, role: examined, excerpt: "When the scope has no `spec/` directory, a `quire trace` query succeeds and lists no `formalizes` relation, rather than failing on the missing document root."} + - {id: FR-045-AC-6, path: spec/functional/FR-045-trace-formalizes-output.md, role: examined, excerpt: "Human `quire trace` output prints each relation as `formalized by ::