Skip to content

Aircraft Carrier ramp state is serialized out of bounds #2995

Description

@bobtista

FlightDeckBehavior::xfer serializes the launch ramp flags with an out-of-bounds array index (m_rampUp[MAX_RUNWAYS] inside a loop over MAX_RUNWAYS), so the real ramp state is never saved or restored and one element is read/written past the end of the array on every save and load.

Found while investigating #2994; I'm not sure if it's observable in-game though, maybe it causes a delay before the next planes take off?

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething is not working right, typically is user facingMinorSeverity: Minor < Major < Critical < BlockerSaveloadIs Saveload/Xfer relatedZHRelates to Zero Hour

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions