From 5a1d77fbf881f93f305025b22dd27007a4b99ba4 Mon Sep 17 00:00:00 2001 From: Dara Adedeji Date: Fri, 31 Jul 2026 00:22:22 -0700 Subject: [PATCH 1/2] Fix the shared-renderer client contains-check pattern MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The slice-3 review hardening reworded the disconnect log to 'host gone or wedged, will reconnect' after the check step pinned the original phrasing; pin the invariant ('will reconnect' — the reconnect promise) rather than the exact prose. --- build.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.zig b/build.zig index 84946d15..45f0d943 100644 --- a/build.zig +++ b/build.zig @@ -600,7 +600,7 @@ pub fn build(b: *std.Build) void { // Lazy connect + reconnect-after-crash, the Windows // shared_renderer_client semantics. .{ .path = "src/platform/macos/appkit_host.m", .pattern = "will keep retrying" }, - .{ .path = "src/platform/macos/appkit_host.m", .pattern = "host gone, will reconnect" }, + .{ .path = "src/platform/macos/appkit_host.m", .pattern = "will reconnect" }, // A hung host trips the reply tripwire and is treated as crashed; // the widget's main thread never blocks indefinitely. .{ .path = "src/platform/macos/appkit_host.m", .pattern = "NativeSdkSharedRendererReplyTimeoutMs = 5000" }, From e9e46ab6bc48c928b87a6bd52b4e1b7918bc9628 Mon Sep 17 00:00:00 2001 From: Dara Adedeji Date: Fri, 31 Jul 2026 00:28:46 -0700 Subject: [PATCH 2/2] Pin the exact reconnect log line, not a substring Review is right that a bare 'will reconnect' substring could be satisfied by unrelated prose; pin the frame-send failure branch's exact current line instead. --- build.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.zig b/build.zig index 45f0d943..f9793ed8 100644 --- a/build.zig +++ b/build.zig @@ -600,7 +600,7 @@ pub fn build(b: *std.Build) void { // Lazy connect + reconnect-after-crash, the Windows // shared_renderer_client semantics. .{ .path = "src/platform/macos/appkit_host.m", .pattern = "will keep retrying" }, - .{ .path = "src/platform/macos/appkit_host.m", .pattern = "will reconnect" }, + .{ .path = "src/platform/macos/appkit_host.m", .pattern = "host gone or wedged, will reconnect" }, // A hung host trips the reply tripwire and is treated as crashed; // the widget's main thread never blocks indefinitely. .{ .path = "src/platform/macos/appkit_host.m", .pattern = "NativeSdkSharedRendererReplyTimeoutMs = 5000" },