+
{% translate "If you have selected a payment method, you can continue to Review to check and change your responses. Fees must be confirmed before you submit your filing." %}
diff --git a/efile_app/efile/tests/conftest.py b/efile_app/efile/tests/conftest.py
index 9824b5db..5788d478 100644
--- a/efile_app/efile/tests/conftest.py
+++ b/efile_app/efile/tests/conftest.py
@@ -41,3 +41,13 @@ def appellate_code_lists(monkeypatch):
def efsp_validation_metadata(monkeypatch):
"""Validation lookup tests opt into metadata; other tests use USPS fallback."""
monkeypatch.setattr("efile.services.efsp_validation.RuleLookups.get", lambda *args: None)
+
+
+@pytest.fixture(autouse=True)
+def court_headings(monkeypatch):
+ """Search and the court dropdown drop no heading courts unless a test opts in.
+
+ Tests of the court lists themselves call court_selection directly.
+ """
+ monkeypatch.setattr("efile.services.filing_code_search.heading_court_codes", lambda *args: frozenset())
+ monkeypatch.setattr("efile.api.dropdown_views.heading_court_codes", lambda *args: frozenset())
diff --git a/efile_app/efile/tests/test_court_selection.py b/efile_app/efile/tests/test_court_selection.py
index e748fdde..c2f4ebd8 100644
--- a/efile_app/efile/tests/test_court_selection.py
+++ b/efile_app/efile/tests/test_court_selection.py
@@ -410,6 +410,28 @@ def test_a_county_that_only_heads_its_divisions_is_not_offered(self):
courts = self._fetch(payload, [{"code": "cook:cvd1"}, {"code": "will"}])
assert [court["value"] for court in courts] == ["cook:chd", "cook:cvd1", "will"]
+ def test_a_division_heading_over_fileable_locations_is_not_offered(self):
+ payload = [
+ {"code": "cook:cvd", "name": "Cook County - Municipal Civil"},
+ {"code": "cook:cvd2", "name": "Cook County - Municipal Civil - District 2 - Skokie"},
+ {"code": "cook:eld1", "name": "Cook County - Elder Law - District 1 - Chicago"},
+ ]
+ # Elder Law takes filings although the fileable list leaves it out;
+ # only a row heading a location the service does list is dropped.
+ courts = self._fetch(payload, [payload[1]])
+ assert sorted(court["value"] for court in courts) == ["cook:cvd2", "cook:eld1"]
+
+ def test_courts_missing_from_the_fileable_list_are_still_offered(self):
+ # Massachusetts lists almost none of its District Courts as fileable,
+ # and a bare number is not a prefix of other courts' codes.
+ payload = [
+ {"code": "1", "name": "Supreme Judicial Court"},
+ {"code": "490", "name": "District Court - Cambridge"},
+ {"code": "1036:BA", "name": "Juvenile Court -- Barnstable County -- Barnstable"},
+ ]
+ courts = self._fetch(payload, [payload[2]])
+ assert sorted(court["value"] for court in courts) == ["1", "1036:BA", "490"]
+
def test_nothing_is_dropped_when_the_fileable_list_cannot_be_read(self):
payload = [
{"code": "cook", "name": "Cook County"},
diff --git a/efile_app/efile/tests/test_filing_code_search.py b/efile_app/efile/tests/test_filing_code_search.py
index 7f360d7d..87b859f3 100644
--- a/efile_app/efile/tests/test_filing_code_search.py
+++ b/efile_app/efile/tests/test_filing_code_search.py
@@ -6,12 +6,14 @@
import pytest
import requests
+from django.core.cache import cache
from django.core.management import call_command
from django.core.management.base import CommandError
from django.db import connection, transaction
from django.urls import reverse
from efile.models import FilingDocument, FilingDraft, FilingParty
+from efile.services import court_selection
from efile.services.filing_code_search import (
CodeCatalog,
concept_definitions,
@@ -1187,3 +1189,63 @@ def test_other_stage_count_points_new_case_searches_at_existing_filings(catalog)
assert new["other_stage_total"] == existing["total"]
assert existing["other_stage_total"] == new["total"]
assert search_grouped_paths(index, "eviction", initial=True, offset=20)["other_stage_total"] is None
+
+
+def test_search_reuses_index_metadata_across_results(index, django_assert_num_queries):
+ # Keep real serialization: it accesses path.index for vocabulary and state
+ # guidance. Every result must reuse the already loaded index, without a
+ # join that decodes its potentially multi-megabyte JSON again per row.
+ from efile.models import FilingCodeIndex
+ from efile.services.filing_code_search import serialize_path
+
+ def serialize_known_index(path, **kwargs):
+ assert path.index is index
+ return serialize_path(path, **kwargs)
+
+ with (
+ patch.object(FilingCodeIndex, "from_db", side_effect=AssertionError("Refetched index metadata")),
+ patch("efile.services.filing_code_search.serialize_path", side_effect=serialize_known_index),
+ django_assert_num_queries(2),
+ ):
+ result = search_paths(index, "eviction", limit=500)
+ assert result["total"] == 2
+ assert {path["court"]["code"] for path in result["results"]} == {"housing", "district"}
+
+
+def test_search_index_leaves_import_snapshots_lazy(index, django_assert_num_queries):
+ expected_snapshots = index.court_snapshots
+ with django_assert_num_queries(1):
+ loaded = current_index("massachusetts")
+ assert loaded is not None
+ assert loaded.vocabulary == index.vocabulary
+ assert loaded.get_deferred_fields() == {"court_snapshots"}
+ with django_assert_num_queries(1):
+ assert loaded.court_snapshots == expected_snapshots
+
+
+def test_search_leaves_out_heading_courts_even_in_an_older_index(index, monkeypatch):
+ monkeypatch.setattr("efile.services.filing_code_search.heading_court_codes", lambda jurisdiction: {"district"})
+ paths, _ = matching_paths(index, "eviction", True)
+ codes = set(paths.values_list("court__code", flat=True))
+ assert codes
+ assert "district" not in codes
+
+
+def test_live_validation_rejects_a_heading_court(index, catalog, monkeypatch):
+ path = index.paths.filter(initial=True).first()
+ monkeypatch.setattr(
+ "efile.services.filing_code_search.heading_court_codes", lambda jurisdiction: {path.court["code"]}
+ )
+ catalog.categories.reset_mock()
+ with pytest.raises(ValueError, match="no longer offered"):
+ validate_path(path)
+ catalog.categories.assert_not_called()
+
+
+def test_unreadable_court_lists_drop_nothing_and_are_not_refetched_per_search():
+ cache.clear()
+ with patch("efile.services.court_selection.requests.get", side_effect=requests.Timeout()) as get:
+ assert court_selection.heading_court_codes("massachusetts") == frozenset()
+ assert court_selection.heading_court_codes("massachusetts") == frozenset()
+ assert get.call_count == 1
+ cache.clear()
diff --git a/efile_app/efile/tests/test_managed_waiver.py b/efile_app/efile/tests/test_managed_waiver.py
index a30e5703..9c369adb 100644
--- a/efile_app/efile/tests/test_managed_waiver.py
+++ b/efile_app/efile/tests/test_managed_waiver.py
@@ -186,3 +186,22 @@ def test_statutory_exemption_choice_does_not_claim_low_income(client, payment_dr
assert "I think I qualify for a fee waiver" not in body
assert "You do not need to qualify based on income" in body
assert "Add fee waiver documents" not in body
+
+
+def test_payment_without_a_fee_quote_can_open_review_for_corrections(client, payment_draft):
+ assert payment_draft.quoted_fee_total == ""
+ with patch(
+ "efile.views.payment.payment_accounts",
+ return_value=[{"paymentAccountID": "card", "paymentAccountTypeCode": "CC", "accountName": "My card"}],
+ ):
+ result = client.post(
+ reverse("payment", kwargs={"jurisdiction": "illinois"}),
+ {"selected_payment_account": "card"},
+ )
+ assert result.status_code == 302
+ review = client.get(result.url)
+ assert review.status_code == 200
+ assert "return_to=review" in review.content.decode()
+ payment_draft.refresh_from_db()
+ assert payment_draft.selected_payment_account_id == "card"
+ assert payment_draft.quoted_fee_total == ""
diff --git a/efile_app/js-tests/payment.test.js b/efile_app/js-tests/payment.test.js
index 7c86ca19..b94c339d 100644
--- a/efile_app/js-tests/payment.test.js
+++ b/efile_app/js-tests/payment.test.js
@@ -60,6 +60,7 @@ function pageHarness(post, checks = {
vm.runInContext(fs.readFileSync(path.join(__dirname, "../efile/static/js/payment.js"), "utf8") +
"\nglobalThis.payment = PaymentPage;", context);
return {
+ context,
payment: context.payment,
window: context.window,
apiUtils: context.apiUtils,
@@ -314,6 +315,7 @@ test("failed removal keeps the existing payment selection usable and permits ret
node("selected-payment-account").value = "card";
node("selected-payment-account-name").value = "My card";
node("paymentSection").hidden = false;
+ node("feeQuoteHelp").hidden = false;
payment.feeQuoteReady = true;
payment.quoteRequestId = 7;
apiUtils.delete = async () => {
@@ -329,6 +331,7 @@ test("failed removal keeps the existing payment selection usable and permits ret
assert.equal(button.disabled, false);
assert.equal(payment.removingAccount, false);
assert.equal(node("errorMessage").hidden, false);
+ assert.equal(node("feeQuoteHelp").hidden, true);
assert.equal(node("selected-payment-account").value, "card");
assert.equal(node("selected-payment-account-name").value, "My card");
assert.equal(node("paymentSection").hidden, false);
@@ -350,4 +353,37 @@ test("a copy still waiting to be checked keeps review disabled", async () => {
pending = false;
payment.setFeesState(false);
assert.equal(node("submitButton").disabled, false);
+});
+
+test("a rejected fee quote still lets the filer continue to Review", async () => {
+ const {
+ payment,
+ node,
+ apiUtils,
+ context
+ } = pageHarness(async () => {
+ throw {
+ serverMessage: "This court cannot accept an initial filing"
+ };
+ });
+ context.ApiUtils = {
+ FEE_TIMEOUT_MS: 1000
+ };
+ context.FilingPayload.userDataFromCaseData = () => ({});
+ context.document.querySelector = () => ({
+ value: "card",
+ dataset: {
+ name: "My card",
+ type: "CC"
+ }
+ });
+ apiUtils.getUploadData = async () => ({});
+ payment.buildEFilingData = () => ({});
+ await payment.selectAndQuote();
+ assert.equal(payment.feeQuoteReady, false);
+ assert.equal(node("errorMessage").hidden, false);
+ assert.match(node("errorText").textContent, /cannot accept an initial filing/);
+ assert.equal(node("feeQuoteHelp").hidden, false);
+ assert.equal(node("selected-payment-account").value, "card");
+ assert.equal(node("submitButton").disabled, false);
});
\ No newline at end of file