Skip to content

curl_close() deprecation and float casting to integer #1

Description

@ChristianHMeier

Greetings,

I have recently started a project of my own, employing your library in order to execute Solana transactions.

During the tests, I found warnings like this showing up in my debug log:

Function curl_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in path\to\solana-php\Rpc\Http\CurlHttpClient.php on line 86
PHP Warning: The float 1.8446744073709552E+19 is not representable as an int, cast occurred in path\to\solana-php\Rpc\RpcClient.php on line 419

On account you already set the project to have PHP 8.0 as the minimum version, I think it is safe to delete the curl_close() call from CurlHttpClient, in order to future-proof against the incoming removal of the function.

The second is trickier, and unfortunately I don't know of a possible solution.

These warnings were activated when I was testing the getBalance() method from RcpClient, when testing if a given address had enough of a lamports balance to sponsor the transactions on behalf of both payer and payee.

I hope this feedback helps you improve your project, I'm looking forward to work with it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions