From f439644169b8ba80f2e707eba00ccd3b20fd5114 Mon Sep 17 00:00:00 2001 From: Alfonso Noriega Date: Mon, 13 Jul 2026 11:55:46 +0200 Subject: [PATCH] Tighten Cloudflare install test mock types --- .../plugin-cloudflare/src/install-cloudflared.test.ts | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/plugin-cloudflare/src/install-cloudflared.test.ts b/packages/plugin-cloudflare/src/install-cloudflared.test.ts index a72f73ae6db..e29f90669bf 100644 --- a/packages/plugin-cloudflare/src/install-cloudflared.test.ts +++ b/packages/plugin-cloudflare/src/install-cloudflared.test.ts @@ -3,7 +3,7 @@ import * as http from '@shopify/cli-kit/node/http' import {inTemporaryDirectory, readFile, writeFile, fileExists} from '@shopify/cli-kit/node/fs' import {joinPath} from '@shopify/cli-kit/node/path' import {describe, expect, test, vi} from 'vitest' -import {Readable} from 'stream' +import {Response} from 'node-fetch' import {writeFileSync} from 'fs' // eslint-disable-next-line no-restricted-imports import * as childProcess from 'child_process' @@ -14,12 +14,9 @@ vi.mock('child_process') describe('install-cloudflare', () => { const mockFetch = (ok = true) => { - vi.mocked(http.fetch).mockResolvedValue({ - ok, - status: ok ? 200 : 404, - statusText: ok ? 'OK' : 'Not Found', - body: Readable.from(['cloudflared content']), - } as any) + vi.mocked(http.fetch).mockResolvedValue( + new Response('cloudflared content', {status: ok ? 200 : 404, statusText: ok ? 'OK' : 'Not Found'}), + ) } test('install is ignored if SHOPIFY_CLI_IGNORE_CLOUDFLARED is present', async () => {