From dd8484b3bbd1746ddf2bc97a7467c6d59e657020 Mon Sep 17 00:00:00 2001 From: 2Pacalypse- Date: Wed, 28 Oct 2026 00:15:36 +0100 Subject: [PATCH] Raise the default CHK chunks per tag limit to the total chunk limit Tribe Control 1.4, a released map, pads its CHK with 16,396 mostly empty chunks under an all-zero tag and was rejected one chunk over the 16 Ki default. Every retained chunk already counts toward max_chk_chunks, so matching that limit keeps memory bounded the same way. --- broodmap/src/chk/mod.rs | 10 ++++++++++ broodmap/src/limits.rs | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/broodmap/src/chk/mod.rs b/broodmap/src/chk/mod.rs index f36ae51..a756b8c 100644 --- a/broodmap/src/chk/mod.rs +++ b/broodmap/src/chk/mod.rs @@ -1313,6 +1313,16 @@ mod tests { )); } + #[test] + fn default_limits_accept_many_padding_chunks_for_one_tag() { + // A released map (Tribe Control 1.4) pads its CHK with 16,396 mostly empty chunks under an + // all-zero tag. + let data = chunk(*b"\0\0\0\0", &[]).repeat(16 * 1024 + 12); + + let sections = gather_chunk_map(&data, &ResourceLimits::default()).unwrap(); + assert_eq!(sections[b"\0\0\0\0"].len(), 16 * 1024 + 12); + } + #[test] fn resource_limit_rejects_oversized_appended_chunk_data() { let data = [chunk(*b"UNIT", b"abc"), chunk(*b"UNIT", b"def")].concat(); diff --git a/broodmap/src/limits.rs b/broodmap/src/limits.rs index 1baf47c..e9e791d 100644 --- a/broodmap/src/limits.rs +++ b/broodmap/src/limits.rs @@ -78,7 +78,7 @@ impl Default for ResourceLimits { max_mpq_file_sectors: 128 * 1024, max_chk_bytes: 64 * MIB, max_chk_chunks: 64 * 1024, - max_chk_chunks_per_tag: 16 * 1024, + max_chk_chunks_per_tag: 64 * 1024, max_merged_chunk_bytes: 64 * MIB, } }