diff --git a/src/CodeEditor.tsx b/src/CodeEditor.tsx index c5c2aa9..a25195e 100644 --- a/src/CodeEditor.tsx +++ b/src/CodeEditor.tsx @@ -285,7 +285,8 @@ export const CodeEditor = forwardRef(function Co onEditorBlur={onBlurCallback} onContentSizeChange={onContentSizeChangeCallback} decorations={nativeDecorations} - decorationsRevision={decorationsRevision} + // A removed prop clears for the current text, since a revision older than the edit log is ignored. + decorationsRevision={decorations ? decorationsRevision : -1} onGapLayout={gapsListened.current ? onGapLayoutCallback : undefined} hybridRef={hybridRef} /> diff --git a/src/__tests__/CodeEditor.test.tsx b/src/__tests__/CodeEditor.test.tsx index 1456d79..933e200 100644 --- a/src/__tests__/CodeEditor.test.tsx +++ b/src/__tests__/CodeEditor.test.tsx @@ -389,6 +389,14 @@ describe('CodeEditor', () => { expect(empty.decorationsRevision).toBe(-1); }); + it('clears removed decorations for the current text, whatever decorationsRevision says', async () => { + const decorations: Decoration[] = [{ kind: 'gap', line: 1, rows: 2 }]; + const api = await render(); + await api.rerender(); + expect(host(api).decorations).toEqual([]); + expect(host(api).decorationsRevision).toBe(-1); + }); + it('wires onGapLayout once a handler was set', async () => { const api = await render(); expect(host(api).onGapLayout).toBeUndefined();