Audio popping when pausing audio playback

[tpaau]

I noticed a distinct popping sound when pausing audio playback in rodio that doesn't occur in any media players I tried with same audio files. This happens both in the development preset and release preset.

I create my Player like so:

let handle = rodio::DeviceSinkBuilder::open_default_sink().unwrap();
let player = Player::connect_new(handle.mixer());

And this is how I open my audio sources:

let file = File::open(path).unwrap();
let source = Decoder::try_from(file).unwrap();
player.append(source);

Rodio 0.22.2 with default features and the "64bit" feature enabled.

[yara-blue]

Are you running with "--release"?

If that is not it then what you need is a short fadeout before pausing (like 10ms) and a fadeIn when resuming. This should be added to Rodios Pausable struct but it is not sadly. Feel free to take that on and add it though!

[tpaau]

Yes, I'm building with the --release flag.

As for the fade in/out, I found Source::fade_in, and Source::fade_out. They both seem to be applying the effect to the start of the source, which is fine for fade_in, but I have no idea how to achieve the fade out effect when pausing.

Do I need to remove the source, add it back again with the fade out effect applied, seek the player and then pause after the 10ms timeout has passed?

[yara-blue]

but I have no idea how to achieve the fade out effect when pausing.

we should have that in rodio build in. We don't right now. So what needs to happen is someone needs to modify the Pausable source in rodio to add a short fadein/fadeout (simply by changing the samples and delaying the pause by a few samples). Nothing you can do easily in your own code. But feel free to try and contribute!