From e32775179659475c3560b842125009692aaaeb5a Mon Sep 17 00:00:00 2001 From: Eduardo Montovanelli Dalmaso Date: Thu, 19 Nov 2026 18:50:43 -0300 Subject: [PATCH] Fix Arcane Cloak using negative unreserved mana (#5411) --- spec/System/TestDefence_spec.lua | 15 +++++++++++++++ src/Classes/ModStore.lua | 5 ++--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/spec/System/TestDefence_spec.lua b/spec/System/TestDefence_spec.lua index 1a7f3289598..4aa38717d16 100644 --- a/spec/System/TestDefence_spec.lua +++ b/spec/System/TestDefence_spec.lua @@ -1884,4 +1884,19 @@ describe("TestDefence", function() assert.is_true(higherResistEHP >= lowerResistEHP, string.format("EHP fell from %.1f to %.1f", lowerResistEHP, higherResistEHP)) end) + + it("treats negative unreserved mana as 0 for Arcane Cloak", function() + newBuild() + build.skillsTab:PasteSocketGroup("Arc 20/0 1") + build.skillsTab:PasteSocketGroup("Determination 20/0 1\nPride 20/0 1\nMalevolence 20/0 1") + build.mainSocketGroup = 1 + runCallback("OnFrame") + local baseDPS = build.calcsTab.mainOutput.TotalDPS + + build.skillsTab:PasteSocketGroup("Arcane Cloak 20/0 1") + runCallback("OnFrame") + local output = build.calcsTab.mainOutput + assert.is_true(output.ManaUnreserved < 0) + assert.are.equal(baseDPS, output.TotalDPS) + end) end) diff --git a/src/Classes/ModStore.lua b/src/Classes/ModStore.lua index 506925c0cbd..57f717049bd 100644 --- a/src/Classes/ModStore.lua +++ b/src/Classes/ModStore.lua @@ -345,9 +345,8 @@ function ModStoreClass:GetStat(stat, cfg) -- 0% reserved = total mana return self.actor.output["Mana"] elseif stat == "ManaUnreserved" and self.actor.output[stat] ~= nil and self.actor.output[stat] < 0 then - -- This reverse engineers how much mana is unreserved before efficiency for accurate Arcane Cloak calcs - local reservedPercentBeforeEfficiency = (math.abs(self.actor.output["ManaUnreservedPercent"]) + 100) * ((100 + self.actor["ManaEfficiency"]) / 100) - return self.actor.output["Mana"] * (math.ceil(reservedPercentBeforeEfficiency) / 100); + -- Negative unreserved mana means 0 mana is available for skills like Arcane Cloak + return 0 else return (self.actor.output and self.actor.output[stat]) or (cfg and cfg.skillStats and cfg.skillStats[stat]) or 0 end