From 2f26647bec4464fafae9491b968ab571c9dd22ab Mon Sep 17 00:00:00 2001 From: Lucas Karsten Date: Thu, 19 Nov 2026 12:05:46 -0300 Subject: [PATCH 1/2] Fix Consecrated Ground you create grants mods not scaling with Consecrated Ground effect --- spec/System/TestDefence_spec.lua | 24 ++++++++++++++++++++++++ src/Data/ModCache.lua | 14 ++++++++------ src/Modules/CalcPerform.lua | 3 +++ src/Modules/ModParser.lua | 2 +- 4 files changed, 36 insertions(+), 7 deletions(-) diff --git a/spec/System/TestDefence_spec.lua b/spec/System/TestDefence_spec.lua index 1a7f3289598..5a0ed18da49 100644 --- a/spec/System/TestDefence_spec.lua +++ b/spec/System/TestDefence_spec.lua @@ -169,6 +169,30 @@ describe("TestDefence", function() assert.is_true(fireResistOnConsecratedGround > build.calcsTab.mainOutput.FireResist) end) + it("scales Consecrated Ground you create grants mods with Consecrated Ground effect (issue #9696)", function() + local function measure(effect) + newBuild() + build.configTab.input.conditionOnConsecratedGround = true + build.configTab.input.customMods = "Consecrated Ground you create grants 30% increased Mana Regeneration\n" + .. "Consecrated Ground you create grants +2% maximum Chaos Resistance to you and Allies\n" + .. "Consecrated Ground you create also grants 50% reduced duration of Damaging Ailments on you\n" + .. (effect and effect .. "% increased Effect of Consecrated Ground you create" or "") + build.configTab:BuildModList() + runCallback("OnFrame") + local modDB = build.calcsTab.mainEnv.player.modDB + return build.calcsTab.mainOutput.ManaRegenInc, modDB:Sum("BASE", nil, "ChaosResistMax"), modDB:Sum("INC", nil, "SelfIgniteDuration") + end + local manaInc, chaosMax, igniteDuration = measure() + assert.are.equals(30, manaInc) + local baseChaosMax = chaosMax + assert.are.equals(-50, igniteDuration) + + manaInc, chaosMax, igniteDuration = measure(50) + assert.are.equals(45, manaInc) + assert.are.equals(baseChaosMax + 1, chaosMax) + assert.are.equals(-75, igniteDuration) + end) + -- boring part it("no armour max hits", function() build.configTab.input.enemyIsBoss = "None" diff --git a/src/Data/ModCache.lua b/src/Data/ModCache.lua index da1918b9f96..d5826f47a4e 100755 --- a/src/Data/ModCache.lua +++ b/src/Data/ModCache.lua @@ -15128,18 +15128,18 @@ c["Consecrated Ground created by this Flask has Tripled Radius +2% to Critical S c["Consecrated Ground created during Effect applies 10% increased Damage taken to Enemies"]={{[1]={[1]={type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="EnemyModifier",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="DamageTakenConsecratedGround",type="INC",value=10}}}},nil} c["Consecrated Ground created during Effect applies 9% increased Damage taken to Enemies"]={{[1]={[1]={type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="EnemyModifier",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="DamageTakenConsecratedGround",type="INC",value=9}}}},nil} c["Consecrated Ground you create also grants"]={nil,""} -c["Consecrated Ground you create also grants 50% reduced duration of Damaging Ailments on you"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="SelfIgniteDuration",type="INC",value=-50},[2]={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="SelfBleedDuration",type="INC",value=-50},[3]={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="SelfPoisonDuration",type="INC",value=-50}},nil} +c["Consecrated Ground you create also grants 50% reduced duration of Damaging Ailments on you"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},[2]={div=100,noFloor=true,type="Multiplier",var="ConsecratedGroundEffect"},flags=0,keywordFlags=0,name="SelfIgniteDuration",type="INC",value=-50},[2]={[1]={type="Condition",var="OnConsecratedGround"},[2]={div=100,noFloor=true,type="Multiplier",var="ConsecratedGroundEffect"},flags=0,keywordFlags=0,name="SelfBleedDuration",type="INC",value=-50},[3]={[1]={type="Condition",var="OnConsecratedGround"},[2]={div=100,noFloor=true,type="Multiplier",var="ConsecratedGroundEffect"},flags=0,keywordFlags=0,name="SelfPoisonDuration",type="INC",value=-50}},nil} c["Consecrated Ground you create applies 10% increased Damage taken to Enemies"]={{[1]={flags=0,keywordFlags=0,name="EnemyModifier",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="DamageTakenConsecratedGround",type="INC",value=10}}}},nil} c["Consecrated Ground you create applies 15% increased Damage taken to Enemies"]={{[1]={flags=0,keywordFlags=0,name="EnemyModifier",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="DamageTakenConsecratedGround",type="INC",value=15}}}},nil} c["Consecrated Ground you create applies 6% increased Damage taken to Enemies"]={{[1]={flags=0,keywordFlags=0,name="EnemyModifier",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="DamageTakenConsecratedGround",type="INC",value=6}}}},nil} c["Consecrated Ground you create applies 9% increased Damage taken to Enemies"]={{[1]={flags=0,keywordFlags=0,name="EnemyModifier",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="DamageTakenConsecratedGround",type="INC",value=9}}}},nil} c["Consecrated Ground you create causes Life Regeneration to"]={nil,"Consecrated Ground you create causes Life Regeneration to "} c["Consecrated Ground you create causes Life Regeneration to also Recover Energy Shield for you and Allies"]={{[1]={flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="LifeRegenerationRecoversEnergyShield",type="FLAG",value=true}}}},nil} -c["Consecrated Ground you create grants +2% maximum Chaos Resistance to you and Allies"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={flags=0,keywordFlags=0,name="ChaosResistMax",type="BASE",value=2}}}},nil} +c["Consecrated Ground you create grants +2% maximum Chaos Resistance to you and Allies"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},[2]={div=100,noFloor=true,type="Multiplier",var="ConsecratedGroundEffect"},flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={flags=0,keywordFlags=0,name="ChaosResistMax",type="BASE",value=2}}}},nil} c["Consecrated Ground you create grants 30% increased Accuracy Rating to you and Allies"]={{[1]={flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="ConsecratedGroundAlsoAccuracy",type="INC",value=30}}}},nil} -c["Consecrated Ground you create grants 30% increased Mana Regeneration"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="ManaRegen",type="INC",value=30}},nil} -c["Consecrated Ground you create grants 5% reduced damage taken to you and Allies"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={flags=0,keywordFlags=0,name="DamageTaken",type="INC",value=-5}}}},nil} -c["Consecrated Ground you create grants 6% reduced damage taken to you and Allies"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={flags=0,keywordFlags=0,name="DamageTaken",type="INC",value=-6}}}},nil} +c["Consecrated Ground you create grants 30% increased Mana Regeneration"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},[2]={div=100,noFloor=true,type="Multiplier",var="ConsecratedGroundEffect"},flags=0,keywordFlags=0,name="ManaRegen",type="INC",value=30}},nil} +c["Consecrated Ground you create grants 5% reduced damage taken to you and Allies"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},[2]={div=100,noFloor=true,type="Multiplier",var="ConsecratedGroundEffect"},flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={flags=0,keywordFlags=0,name="DamageTaken",type="INC",value=-5}}}},nil} +c["Consecrated Ground you create grants 6% reduced damage taken to you and Allies"]={{[1]={[1]={type="Condition",var="OnConsecratedGround"},[2]={div=100,noFloor=true,type="Multiplier",var="ConsecratedGroundEffect"},flags=0,keywordFlags=0,name="ExtraAura",type="LIST",value={mod={flags=0,keywordFlags=0,name="DamageTaken",type="INC",value=-6}}}},nil} c["Consecrated Ground you create while affected by Zealotry causes enemies to take 10% increased Damage"]={{[1]={[1]={actor="enemy",type="ActorCondition",var="OnConsecratedGround"},[2]={type="Condition",var="AffectedByZealotry"},flags=0,keywordFlags=0,name="EnemyModifier",type="LIST",value={mod={flags=0,keywordFlags=0,name="DamageTakenConsecratedGround",type="INC",value=10}}}},nil} c["Consecrated Ground you create while affected by Zealotry causes enemies to take 9% increased Damage"]={{[1]={[1]={actor="enemy",type="ActorCondition",var="OnConsecratedGround"},[2]={type="Condition",var="AffectedByZealotry"},flags=0,keywordFlags=0,name="EnemyModifier",type="LIST",value={mod={flags=0,keywordFlags=0,name="DamageTakenConsecratedGround",type="INC",value=9}}}},nil} c["Consumes Frenzy Charges on use"]={nil,"Consumes Frenzy Charges on use "} @@ -17725,7 +17725,9 @@ c["Kill Undead Enemies that have 15% or lower Life when Hit by your Skills"]={ni c["Killing Blows Consume corpses to Recover 100 Life"]={nil,"Killing Blows Consume corpses to Recover 100 Life "} c["Killing Blows Consume corpses to Recover 120 Life and 60 Mana"]={nil,"Killing Blows Consume corpses to Recover 120 Life and 60 Mana "} c["Killing Blows Consume corpses to Recover 25 Mana"]={nil,"Killing Blows Consume corpses to Recover 25 Mana "} +c["Killing Blows Consume corpses to Recover 4% of Life"]={nil,"Killing Blows Consume corpses to Recover 4% of Life "} c["Killing Blows Consume corpses to Recover 4% of Mana"]={nil,"Killing Blows Consume corpses to Recover 4% of Mana "} +c["Killing Blows Consume corpses to Recover 4% of Mana Killing Blows Consume corpses to Recover 4% of Life"]={nil,"Killing Blows Consume corpses to Recover 4% of Mana Killing Blows Consume corpses to Recover 4% of Life "} c["Killing Blows Consume corpses to Recover 50 Life"]={nil,"Killing Blows Consume corpses to Recover 50 Life "} c["Killing Blows Consume corpses to Recover 50 Mana"]={nil,"Killing Blows Consume corpses to Recover 50 Mana "} c["Killing Blows Consume corpses to Recover 60 Life and 30 Mana"]={nil,"Killing Blows Consume corpses to Recover 60 Life and 30 Mana "} @@ -20005,9 +20007,9 @@ c["Requires Class Scion Allocates Hierophant if you have the matching modifier o c["Requires Class Scion Allocates Inquisitor if you have the matching modifier on Forbidden Flame"]={nil,"Requires Class Scion Allocates Inquisitor if you have the matching modifier on Forbidden Flame "} c["Requires Class Scion Allocates Inquisitor if you have the matching modifier on Forbidden Flesh"]={nil,"Requires Class Scion Allocates Inquisitor if you have the matching modifier on Forbidden Flesh "} c["Requires Class Scion Allocates Juggernaut if you have the matching modifier on Forbidden Flame"]={nil,"Requires Class Scion Allocates Juggernaut if you have the matching modifier on Forbidden Flame "} +end)();(function() c["Requires Class Scion Allocates Juggernaut if you have the matching modifier on Forbidden Flesh"]={nil,"Requires Class Scion Allocates Juggernaut if you have the matching modifier on Forbidden Flesh "} c["Requires Class Scion Allocates Necromancer if you have the matching modifier on Forbidden Flame"]={nil,"Requires Class Scion Allocates Necromancer if you have the matching modifier on Forbidden Flame "} -end)();(function() c["Requires Class Scion Allocates Necromancer if you have the matching modifier on Forbidden Flesh"]={nil,"Requires Class Scion Allocates Necromancer if you have the matching modifier on Forbidden Flesh "} c["Requires Class Scion Allocates Occultist if you have the matching modifier on Forbidden Flame"]={nil,"Requires Class Scion Allocates Occultist if you have the matching modifier on Forbidden Flame "} c["Requires Class Scion Allocates Occultist if you have the matching modifier on Forbidden Flesh"]={nil,"Requires Class Scion Allocates Occultist if you have the matching modifier on Forbidden Flesh "} diff --git a/src/Modules/CalcPerform.lua b/src/Modules/CalcPerform.lua index 9fe45271561..c123cdb0cdf 100644 --- a/src/Modules/CalcPerform.lua +++ b/src/Modules/CalcPerform.lua @@ -1305,6 +1305,9 @@ function calcs.perform(env, skipEHP) env.keystonesAdded = { } modLib.mergeKeystones(env, env.modDB) + -- Scales "Consecrated Ground you create grants ..." mods + modDB.multipliers["ConsecratedGroundEffect"] = 100 + modDB:Sum("INC", nil, "ConsecratedGroundEffect") + -- Build minion skills for _, activeSkill in ipairs(env.player.activeSkillList) do activeSkill.skillModList = new("ModList"):ModList(activeSkill.baseSkillModList) diff --git a/src/Modules/ModParser.lua b/src/Modules/ModParser.lua index 85e4cd8e3b4..44878867eb4 100644 --- a/src/Modules/ModParser.lua +++ b/src/Modules/ModParser.lua @@ -1321,7 +1321,7 @@ local preFlagList = { ["attacks with energy blades "] = { flags = ModFlag.Attack, tag = { type = "Condition", var = "AffectedByEnergyBlade" } }, ["^for each nearby corpse, "] = { tag = { type = "Multiplier", var = "NearbyCorpse" } }, ["^enemies in your link beams have "] = { tag = { type = "Condition", var = "BetweenYouAndLinkedTarget" }, applyToEnemy = true }, - ["^consecrated ground you create a?l?s?o? ?grants "] = { tag = { type = "Condition", var = "OnConsecratedGround" } }, + ["^consecrated ground you create a?l?s?o? ?grants "] = { tagList = { { type = "Condition", var = "OnConsecratedGround" }, { type = "Multiplier", var = "ConsecratedGroundEffect", div = 100, noFloor = true } } }, -- While in the presence of... ["^while a unique enemy is in your presence, "] = { tag = { type = "ActorCondition", actor = "enemy", var = "RareOrUnique" } }, ["^while a pinnacle atlas boss is in your presence, "] = { tag = { type = "ActorCondition", actor = "enemy", var = "PinnacleBoss" } }, From a3ae7ddc33417d68971b16d3577c0d2640e03737 Mon Sep 17 00:00:00 2001 From: Lucas Karsten Date: Thu, 19 Nov 2026 12:13:54 -0300 Subject: [PATCH 2/2] Keep only Consecrated Ground entries in ModCache and document multiplier timing --- src/Data/ModCache.lua | 4 +--- src/Modules/CalcPerform.lua | 3 ++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Data/ModCache.lua b/src/Data/ModCache.lua index d5826f47a4e..cb3a7d608bf 100755 --- a/src/Data/ModCache.lua +++ b/src/Data/ModCache.lua @@ -17725,9 +17725,7 @@ c["Kill Undead Enemies that have 15% or lower Life when Hit by your Skills"]={ni c["Killing Blows Consume corpses to Recover 100 Life"]={nil,"Killing Blows Consume corpses to Recover 100 Life "} c["Killing Blows Consume corpses to Recover 120 Life and 60 Mana"]={nil,"Killing Blows Consume corpses to Recover 120 Life and 60 Mana "} c["Killing Blows Consume corpses to Recover 25 Mana"]={nil,"Killing Blows Consume corpses to Recover 25 Mana "} -c["Killing Blows Consume corpses to Recover 4% of Life"]={nil,"Killing Blows Consume corpses to Recover 4% of Life "} c["Killing Blows Consume corpses to Recover 4% of Mana"]={nil,"Killing Blows Consume corpses to Recover 4% of Mana "} -c["Killing Blows Consume corpses to Recover 4% of Mana Killing Blows Consume corpses to Recover 4% of Life"]={nil,"Killing Blows Consume corpses to Recover 4% of Mana Killing Blows Consume corpses to Recover 4% of Life "} c["Killing Blows Consume corpses to Recover 50 Life"]={nil,"Killing Blows Consume corpses to Recover 50 Life "} c["Killing Blows Consume corpses to Recover 50 Mana"]={nil,"Killing Blows Consume corpses to Recover 50 Mana "} c["Killing Blows Consume corpses to Recover 60 Life and 30 Mana"]={nil,"Killing Blows Consume corpses to Recover 60 Life and 30 Mana "} @@ -20007,9 +20005,9 @@ c["Requires Class Scion Allocates Hierophant if you have the matching modifier o c["Requires Class Scion Allocates Inquisitor if you have the matching modifier on Forbidden Flame"]={nil,"Requires Class Scion Allocates Inquisitor if you have the matching modifier on Forbidden Flame "} c["Requires Class Scion Allocates Inquisitor if you have the matching modifier on Forbidden Flesh"]={nil,"Requires Class Scion Allocates Inquisitor if you have the matching modifier on Forbidden Flesh "} c["Requires Class Scion Allocates Juggernaut if you have the matching modifier on Forbidden Flame"]={nil,"Requires Class Scion Allocates Juggernaut if you have the matching modifier on Forbidden Flame "} -end)();(function() c["Requires Class Scion Allocates Juggernaut if you have the matching modifier on Forbidden Flesh"]={nil,"Requires Class Scion Allocates Juggernaut if you have the matching modifier on Forbidden Flesh "} c["Requires Class Scion Allocates Necromancer if you have the matching modifier on Forbidden Flame"]={nil,"Requires Class Scion Allocates Necromancer if you have the matching modifier on Forbidden Flame "} +end)();(function() c["Requires Class Scion Allocates Necromancer if you have the matching modifier on Forbidden Flesh"]={nil,"Requires Class Scion Allocates Necromancer if you have the matching modifier on Forbidden Flesh "} c["Requires Class Scion Allocates Occultist if you have the matching modifier on Forbidden Flame"]={nil,"Requires Class Scion Allocates Occultist if you have the matching modifier on Forbidden Flame "} c["Requires Class Scion Allocates Occultist if you have the matching modifier on Forbidden Flesh"]={nil,"Requires Class Scion Allocates Occultist if you have the matching modifier on Forbidden Flesh "} diff --git a/src/Modules/CalcPerform.lua b/src/Modules/CalcPerform.lua index c123cdb0cdf..27fcd9b168a 100644 --- a/src/Modules/CalcPerform.lua +++ b/src/Modules/CalcPerform.lua @@ -1305,7 +1305,8 @@ function calcs.perform(env, skipEHP) env.keystonesAdded = { } modLib.mergeKeystones(env, env.modDB) - -- Scales "Consecrated Ground you create grants ..." mods + -- Scales "Consecrated Ground you create grants ..." mods. Computed once here, before extra auras are applied, + -- so ConsecratedGroundEffect sources added later in this pass are not included modDB.multipliers["ConsecratedGroundEffect"] = 100 + modDB:Sum("INC", nil, "ConsecratedGroundEffect") -- Build minion skills