From d4160c103adfcd8f4338f329b6b5fb7ea505bf7a Mon Sep 17 00:00:00 2001 From: AdamZ Date: Mon, 16 Nov 2026 07:45:12 -0800 Subject: [PATCH 1/3] Fix Screams of the Desiccated shrine modifiers --- src/Data/ModCache.lua | 41 +++++++++++++-------------------------- src/Modules/ModParser.lua | 6 ++++++ 2 files changed, 20 insertions(+), 27 deletions(-) diff --git a/src/Data/ModCache.lua b/src/Data/ModCache.lua index 69383dd0c68..0265770709d 100755 --- a/src/Data/ModCache.lua +++ b/src/Data/ModCache.lua @@ -18767,32 +18767,19 @@ c["Players have +40 to maximum Life for each Empty Red Socket on any Equipped It c["Players have +40 to maximum Life for each Empty Red Socket on any Equipped Item Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item"]={nil,"Players have +40 to maximum Life for each Empty Red Socket on any Equipped Item Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item "} c["Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item"]={nil,"Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item "} c["Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item Players have +18% to all Elemental Resistances for each Empty White Socket"]={nil,"Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item Players have +18% to all Elemental Resistances for each Empty White Socket "} -c["Players have Acceleration Shrine Buff while affected by no Flasks"]={nil,"Players have Acceleration Shrine Buff while affected by no Flasks "} -c["Players have Acceleration Shrine Buff while affected by no Flasks Players have Brutal Shrine Buff while affected by no Flasks"]={nil,"Players have Acceleration Shrine Buff while affected by no Flasks Players have Brutal Shrine Buff while affected by no Flasks "} -c["Players have Brutal Shrine Buff while affected by no Flasks"]={nil,"Players have Brutal Shrine Buff while affected by no Flasks "} -c["Players have Brutal Shrine Buff while affected by no Flasks Players have Greater Freezing Shrine Buff while affected by no Flasks"]={nil,"Players have Brutal Shrine Buff while affected by no Flasks Players have Greater Freezing Shrine Buff while affected by no Flasks "} -c["Players have Diamond Shrine Buff while affected by no Flasks"]={nil,"Players have Diamond Shrine Buff while affected by no Flasks "} -c["Players have Diamond Shrine Buff while affected by no Flasks Players have Echoing Shrine Buff while affected by no Flasks"]={nil,"Players have Diamond Shrine Buff while affected by no Flasks Players have Echoing Shrine Buff while affected by no Flasks "} -c["Players have Echoing Shrine Buff while affected by no Flasks"]={nil,"Players have Echoing Shrine Buff while affected by no Flasks "} -c["Players have Echoing Shrine Buff while affected by no Flasks Players have Gloom Shrine Buff while affected by no Flasks"]={nil,"Players have Echoing Shrine Buff while affected by no Flasks Players have Gloom Shrine Buff while affected by no Flasks "} -c["Players have Gloom Shrine Buff while affected by no Flasks"]={nil,"Players have Gloom Shrine Buff while affected by no Flasks "} -c["Players have Gloom Shrine Buff while affected by no Flasks Players have Impenetrable Shrine Buff while affected by no Flasks"]={nil,"Players have Gloom Shrine Buff while affected by no Flasks Players have Impenetrable Shrine Buff while affected by no Flasks "} -c["Players have Greater Freezing Shrine Buff while affected by no Flasks"]={nil,"Players have Greater Freezing Shrine Buff while affected by no Flasks "} -c["Players have Greater Freezing Shrine Buff while affected by no Flasks 20% increased Effect of Shrine Buffs on you"]={nil,"Players have Greater Freezing Shrine Buff while affected by no Flasks 20% increased Effect of Shrine Buffs on you "} -c["Players have Greater Shocking Shrine Buff while affected by no Flasks"]={nil,"Players have Greater Shocking Shrine Buff while affected by no Flasks "} -c["Players have Greater Shocking Shrine Buff while affected by no Flasks 20% increased Effect of Shrine Buffs on you"]={nil,"Players have Greater Shocking Shrine Buff while affected by no Flasks 20% increased Effect of Shrine Buffs on you "} -c["Players have Greater Skeletal Shrine Buff while affected by no Flasks"]={nil,"Players have Greater Skeletal Shrine Buff while affected by no Flasks "} -c["Players have Greater Skeletal Shrine Buff while affected by no Flasks 20% increased Effect of Shrine Buffs on you"]={nil,"Players have Greater Skeletal Shrine Buff while affected by no Flasks 20% increased Effect of Shrine Buffs on you "} -c["Players have Impenetrable Shrine Buff while affected by no Flasks"]={nil,"Players have Impenetrable Shrine Buff while affected by no Flasks "} -c["Players have Impenetrable Shrine Buff while affected by no Flasks Players have Massive Shrine Buff while affected by no Flasks"]={nil,"Players have Impenetrable Shrine Buff while affected by no Flasks Players have Massive Shrine Buff while affected by no Flasks "} -c["Players have Massive Shrine Buff while affected by no Flasks"]={nil,"Players have Massive Shrine Buff while affected by no Flasks "} -c["Players have Massive Shrine Buff while affected by no Flasks Players have Replenishing Shrine Buff while affected by no Flasks"]={nil,"Players have Massive Shrine Buff while affected by no Flasks Players have Replenishing Shrine Buff while affected by no Flasks "} -c["Players have Replenishing Shrine Buff while affected by no Flasks"]={nil,"Players have Replenishing Shrine Buff while affected by no Flasks "} -c["Players have Replenishing Shrine Buff while affected by no Flasks Players have Resistance Shrine Buff while affected by no Flasks"]={nil,"Players have Replenishing Shrine Buff while affected by no Flasks Players have Resistance Shrine Buff while affected by no Flasks "} -c["Players have Resistance Shrine Buff while affected by no Flasks"]={nil,"Players have Resistance Shrine Buff while affected by no Flasks "} -c["Players have Resistance Shrine Buff while affected by no Flasks Players have Resonating Shrine Buff while affected by no Flasks"]={nil,"Players have Resistance Shrine Buff while affected by no Flasks Players have Resonating Shrine Buff while affected by no Flasks "} -c["Players have Resonating Shrine Buff while affected by no Flasks"]={nil,"Players have Resonating Shrine Buff while affected by no Flasks "} -c["Players have Resonating Shrine Buff while affected by no Flasks Players have Greater Shocking Shrine Buff while affected by no Flasks"]={nil,"Players have Resonating Shrine Buff while affected by no Flasks Players have Greater Shocking Shrine Buff while affected by no Flasks "} +c["Players have Acceleration Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:AccelerationShrine",type="FLAG",value=true}},nil} +c["Players have Brutal Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:BrutalShrine",type="FLAG",value=true}},nil} +c["Players have Diamond Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:DiamondShrine",type="FLAG",value=true}},nil} +c["Players have Echoing Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:EchoingShrine",type="FLAG",value=true}},nil} +c["Players have Gloom Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:GloomShrine",type="FLAG",value=true}},nil} +c["Players have Greater Freezing Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:GreaterFreezingShrine",type="FLAG",value=true}},nil} +c["Players have Greater Shocking Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:GreaterShockingShrine",type="FLAG",value=true}},nil} +c["Players have Greater Skeletal Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:GreaterSkeletalShrine",type="FLAG",value=true}},nil} +c["Players have Impenetrable Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:ImpenetrableShrine",type="FLAG",value=true}},nil} +c["Players have Massive Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:MassiveShrine",type="FLAG",value=true}},nil} +c["Players have Replenishing Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:ReplenishingShrine",type="FLAG",value=true}},nil} +c["Players have Resistance Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:ResistanceShrine",type="FLAG",value=true}},nil} +c["Players have Resonating Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:ResonatingShrine",type="FLAG",value=true}},nil} c["Point Blank"]={{[1]={flags=0,keywordFlags=0,name="Keystone",type="LIST",value="Point Blank"},[2]={flags=0,keywordFlags=0,name="Condition:HavePointBlank",type="FLAG",value=true}},nil} c["Poison Cursed Enemies on hit"]={{[1]={[1]={actor="enemy",type="ActorCondition",var="Cursed"},flags=0,keywordFlags=0,name="PoisonChance",type="BASE",value=100}},nil} c["Poison you inflict is Reflected to you if you have fewer than 100 Poisons on you"]={nil,"Poison you inflict is Reflected to you if you have fewer than 100 Poisons on you "} @@ -20007,7 +19994,6 @@ c["Retaliation Skills become Usable for an additional 2 seconds"]={nil,"Retaliat c["Retaliation Skills become Usable for an additional 2 seconds 50% chance for used Retaliation Skills to remain Usable and not consume a Cooldown Use"]={nil,"Retaliation Skills become Usable for an additional 2 seconds 50% chance for used Retaliation Skills to remain Usable and not consume a Cooldown Use "} c["Retaliation Skills deal 100% increased Damage"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="Damage",type="INC",value=100}},nil} c["Retaliation Skills deal 12% increased Damage"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="Damage",type="INC",value=12}},nil} -end)();(function() c["Retaliation Skills deal 15% increased Damage"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="Damage",type="INC",value=15}},nil} c["Retaliation Skills deal 16% increased Damage"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="Damage",type="INC",value=16}},nil} c["Retaliation Skills deal 20% increased Damage"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="Damage",type="INC",value=20}},nil} @@ -20021,6 +20007,7 @@ c["Retaliation Skills have 15% increased Cooldown Recovery Rate"]={{[1]={[1]={sk c["Retaliation Skills have 20% increased Speed"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="Speed",type="INC",value=20},[2]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=4,name="WarcrySpeed",type="INC",value=20}},nil} c["Retaliation Skills have 200% Arcane Might"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="SpellDamageAppliesToAttacks",type="FLAG",value=true},[2]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="ImprovedSpellDamageAppliesToAttacks",type="MAX",value=200}},nil} c["Retaliation Skills have 25% increased Stun Duration on Enemies"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="EnemyStunDuration",type="INC",value=25}},nil} +end)();(function() c["Retaliation Skills have 30% increased Area of Effect"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="AreaOfEffect",type="INC",value=30}},nil} c["Retaliation Skills have 30% increased Cooldown Recovery Rate"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="CooldownRecovery",type="INC",value=30}},nil} c["Retaliation Skills have 50% increased Stun Duration on Enemies"]={{[1]={[1]={skillType=121,type="SkillType"},flags=0,keywordFlags=0,name="EnemyStunDuration",type="INC",value=50}},nil} diff --git a/src/Modules/ModParser.lua b/src/Modules/ModParser.lua index 8028d894c9b..0875a4aa134 100644 --- a/src/Modules/ModParser.lua +++ b/src/Modules/ModParser.lua @@ -5724,6 +5724,12 @@ local specialModList = { ["skills supported by unleash have (%d+)%% increased seal gain frequency"] = function(num) return { mod("SealGainFrequency", "INC", num) } end, ["(%d+)%% increased critical strike chance with spells which remove the maximum number of seals"] = function(num) return { mod("MaxSealCrit", "INC", num) } end, ["gain elusive on critical strike"] = { flag("Condition:CanBeElusive") }, + ["players have ([%a%s]+ shrine buff) while affected by no flasks"] = function(_, shrine) + local condition = modNameList[shrine] + if condition then + return { flag(condition, { type = "Condition", var = "UsingFlask", neg = true }) } + end + end, ["gain a random shrine buff every (%d+) seconds"] = { flag("Condition:CanHaveRegularShrines") }, ["gain a random shrine buff for (%d+) seconds when you kill a rare or unique enemy"] = { flag("Condition:CanHaveRegularShrines") }, ["gain a random blood shrine buff every (%d+) seconds"] = { flag("Condition:CanHaveBloodShrines") }, From 0632b0c56de5ba3c37137460c76d2770e4fefe13 Mon Sep 17 00:00:00 2001 From: AdamZ Date: Mon, 16 Nov 2026 11:59:38 -0800 Subject: [PATCH 2/3] Mark Screams of the Desiccated as obtainable --- src/Data/Uniques/belt.lua | 2 +- src/Export/Uniques/belt.lua | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Data/Uniques/belt.lua b/src/Data/Uniques/belt.lua index 0cfa0102bf4..3180dfe02d6 100644 --- a/src/Data/Uniques/belt.lua +++ b/src/Data/Uniques/belt.lua @@ -759,7 +759,7 @@ Grants Level 20 Caustic Retribution Screams of the Desiccated Leather Belt League: Mirage -Source: No longer obtainable +Source: Drops from unique{Saresh, of the Weeping Black} Has Alt Variant: true Selected Variant: 1 Selected Alt Variant: 1 diff --git a/src/Export/Uniques/belt.lua b/src/Export/Uniques/belt.lua index 1b4ba9e1b38..37bf033a4fe 100644 --- a/src/Export/Uniques/belt.lua +++ b/src/Export/Uniques/belt.lua @@ -713,7 +713,7 @@ BitingBraidUniqueBelt52 Screams of the Desiccated Leather Belt League: Mirage -Source: No longer obtainable +Source: Drops from unique{Saresh, of the Weeping Black} Has Alt Variant: true Selected Variant: 1 Selected Alt Variant: 1 From 48824bb990e7a18aceb5ecddcd28ffa2fc33d85e Mon Sep 17 00:00:00 2001 From: Wires77 Date: Mon, 16 Nov 2026 15:19:17 -0600 Subject: [PATCH 3/3] Do partial parsing instead of explicit. This may end up needing to be revisited with Mercenary support --- src/Data/ModCache.lua | 20 ++++++++++---------- src/Modules/ModParser.lua | 7 +------ 2 files changed, 11 insertions(+), 16 deletions(-) diff --git a/src/Data/ModCache.lua b/src/Data/ModCache.lua index 0265770709d..e0ede6c2653 100755 --- a/src/Data/ModCache.lua +++ b/src/Data/ModCache.lua @@ -18757,16 +18757,16 @@ c["Physical Damage of Enemies Hitting you is Unlucky"]={nil,"Physical Damage of c["Physical Damage taken bypasses Energy Shield"]={{[1]={flags=0,keywordFlags=0,name="PhysicalEnergyShieldBypass",type="BASE",value=100}},nil} c["Physical Skills have 1% increased Duration per 12 Intelligence"]={{[1]={[1]={div=12,stat="Int",type="PerStat"},flags=0,keywordFlags=16,name="Duration",type="INC",value=1}},nil} c["Plague Bearer has 20% increased Maximum Plague Value"]={{}," Maximum Plague Value "} -c["Players have +12% to all Elemental Resistances for each Empty White Socket"]={nil,"Players have +12% to all Elemental Resistances for each Empty White Socket "} -c["Players have +12% to all Elemental Resistances for each Empty White Socket on any Equipped Item"]={nil,"Players have +12% to all Elemental Resistances for each Empty White Socket on any Equipped Item "} -c["Players have +18% to all Elemental Resistances for each Empty White Socket"]={nil,"Players have +18% to all Elemental Resistances for each Empty White Socket "} -c["Players have +18% to all Elemental Resistances for each Empty White Socket on any Equipped Item"]={nil,"Players have +18% to all Elemental Resistances for each Empty White Socket on any Equipped Item "} -c["Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item"]={nil,"Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item "} -c["Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item"]={nil,"Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item "} -c["Players have +40 to maximum Life for each Empty Red Socket on any Equipped Item"]={nil,"Players have +40 to maximum Life for each Empty Red Socket on any Equipped Item "} -c["Players have +40 to maximum Life for each Empty Red Socket on any Equipped Item Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item"]={nil,"Players have +40 to maximum Life for each Empty Red Socket on any Equipped Item Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item "} -c["Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item"]={nil,"Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item "} -c["Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item Players have +18% to all Elemental Resistances for each Empty White Socket"]={nil,"Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item Players have +18% to all Elemental Resistances for each Empty White Socket "} +c["Players have +12% to all Elemental Resistances for each Empty White Socket"]={nil,"+12% to all Elemental Resistances for each Empty White Socket "} +c["Players have +12% to all Elemental Resistances for each Empty White Socket on any Equipped Item"]={nil,"+12% to all Elemental Resistances "} +c["Players have +18% to all Elemental Resistances for each Empty White Socket"]={nil,"+18% to all Elemental Resistances for each Empty White Socket "} +c["Players have +18% to all Elemental Resistances for each Empty White Socket on any Equipped Item"]={nil,"+18% to all Elemental Resistances "} +c["Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item"]={nil,"+225 to Accuracy Rating "} +c["Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item"]={nil,"+225 to Accuracy Rating Players have +40 to maximum Mana "} +c["Players have +40 to maximum Life for each Empty Red Socket on any Equipped Item"]={nil,"+40 to maximum Life "} +c["Players have +40 to maximum Life for each Empty Red Socket on any Equipped Item Players have +225 to Accuracy Rating for each Empty Green Socket on any Equipped Item"]={nil,"+40 to maximum Life Players have +225 to Accuracy Rating "} +c["Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item"]={nil,"+40 to maximum Mana "} +c["Players have +40 to maximum Mana for each Empty Blue Socket on any Equipped Item Players have +18% to all Elemental Resistances for each Empty White Socket"]={nil,"+40 to maximum Mana Players have +18% to all Elemental Resistances for each Empty White Socket "} c["Players have Acceleration Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:AccelerationShrine",type="FLAG",value=true}},nil} c["Players have Brutal Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:BrutalShrine",type="FLAG",value=true}},nil} c["Players have Diamond Shrine Buff while affected by no Flasks"]={{[1]={[1]={neg=true,type="Condition",var="UsingFlask"},flags=0,keywordFlags=0,name="Condition:DiamondShrine",type="FLAG",value=true}},nil} diff --git a/src/Modules/ModParser.lua b/src/Modules/ModParser.lua index 0875a4aa134..6355f995fea 100644 --- a/src/Modules/ModParser.lua +++ b/src/Modules/ModParser.lua @@ -1292,6 +1292,7 @@ local preFlagList = { ["^hits against you "] = { applyToEnemy = true, flags = ModFlag.Hit }, ["^enemies near your totems deal "] = { applyToEnemy = true }, -- Other + ["^players "] = { }, ["^your flasks grant "] = { }, ["^when hit, "] = { }, ["^you and allies [hgd][ae][via][enl] "] = { }, @@ -5724,12 +5725,6 @@ local specialModList = { ["skills supported by unleash have (%d+)%% increased seal gain frequency"] = function(num) return { mod("SealGainFrequency", "INC", num) } end, ["(%d+)%% increased critical strike chance with spells which remove the maximum number of seals"] = function(num) return { mod("MaxSealCrit", "INC", num) } end, ["gain elusive on critical strike"] = { flag("Condition:CanBeElusive") }, - ["players have ([%a%s]+ shrine buff) while affected by no flasks"] = function(_, shrine) - local condition = modNameList[shrine] - if condition then - return { flag(condition, { type = "Condition", var = "UsingFlask", neg = true }) } - end - end, ["gain a random shrine buff every (%d+) seconds"] = { flag("Condition:CanHaveRegularShrines") }, ["gain a random shrine buff for (%d+) seconds when you kill a rare or unique enemy"] = { flag("Condition:CanHaveRegularShrines") }, ["gain a random blood shrine buff every (%d+) seconds"] = { flag("Condition:CanHaveBloodShrines") },