diff --git a/src/ServiceControl.Persistence.RavenDB/Recoverability/RetryHistoryDataStore.cs b/src/ServiceControl.Persistence.RavenDB/Recoverability/RetryHistoryDataStore.cs index 054359b812..7e270a36af 100644 --- a/src/ServiceControl.Persistence.RavenDB/Recoverability/RetryHistoryDataStore.cs +++ b/src/ServiceControl.Persistence.RavenDB/Recoverability/RetryHistoryDataStore.cs @@ -11,10 +11,9 @@ class RetryHistoryDataStore(IRavenSessionProvider sessionProvider) : IRetryHisto public async Task GetRetryHistory() { using var session = await sessionProvider.OpenSession(); - var id = DocumentId; - var retryHistory = await session.LoadAsync(id); + var retryHistory = await session.LoadAsync(DocumentId); - retryHistory ??= new() { Id = DocumentId }; + retryHistory ??= new(); return retryHistory; } @@ -23,7 +22,7 @@ public async Task RecordRetryOperationCompleted(string requestId, RetryType retr string originator, string classifier, bool messageFailed, int numberOfMessagesProcessed, DateTime lastProcessed, int retryHistoryDepth) { using var session = await sessionProvider.OpenSession(); - var retryHistory = await session.LoadAsync(DocumentId) ?? new() { Id = DocumentId }; + var retryHistory = await session.LoadAsync(DocumentId) ?? new(); retryHistory.AddToUnacknowledged(new UnacknowledgedRetryOperation { @@ -49,7 +48,7 @@ public async Task RecordRetryOperationCompleted(string requestId, RetryType retr NumberOfMessagesProcessed = numberOfMessagesProcessed }, retryHistoryDepth); - await session.StoreAsync(retryHistory); + await session.StoreAsync(retryHistory, DocumentId); await session.SaveChangesAsync(); } @@ -61,7 +60,7 @@ public async Task AcknowledgeRetryGroup(string groupId) { if (retryHistory.Acknowledge(groupId, RetryType.FailureGroup)) { - await session.StoreAsync(retryHistory); + await session.StoreAsync(retryHistory, DocumentId); await session.SaveChangesAsync(); return true; diff --git a/src/ServiceControl.Persistence/RetryHistory.cs b/src/ServiceControl.Persistence/RetryHistory.cs index f736333f67..fffdfdbd23 100644 --- a/src/ServiceControl.Persistence/RetryHistory.cs +++ b/src/ServiceControl.Persistence/RetryHistory.cs @@ -6,7 +6,6 @@ public class RetryHistory { - public string Id { get; set; } public List HistoricOperations { get; set; } = []; public List UnacknowledgedOperations { get; set; } = [];