Skip to content

Is the ProblemDocument class really neessary? #34

Description

@tpluscode

Working some more with this and related libraries I'm repeatedly thinking whether the ProblemDocument really needs to be a class?

Wouldn't it be enough to simply define a contract for a problem document and have mapper return plain objects?

interface ProblemDocument extends Record<string, unknown> {
    detail?: string;
    instance?: string;
    status: number;
    title: string;
    type?: string;
}

class Mapper {
  mapError(error): ProblemDocument {
    return {
      status: 500,
      title: 'Something happened'
    }
  }
}

This would simplify how extensions are implemented and make it easier to work with derived or decorated mappers

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions