fix: skip PDF companion locks when opening EPUBs

Author: reycn

electron/main.mjs

@@ -38,6 +38,7 @@ import { createAppIcon } from './main/services/app-icon.mjs';
 import { createCompanionServer } from './main/services/companion-server.mjs';
 import {
   configureEPUBSupport,
+  isEPUBPath,
   readSystemPDF,
   validateSystemPDF,
   pdfLaunchPaths,
@@ -323,6 +324,8 @@ else {
     return error;
   };
   const claimCompanionID = async (id, target, notificationTarget = target, options = {}) => {
+    // Companion transfer and revision locks operate on source PDF files only.
+    if (isEPUBPath(recents?.path(id))) return { available: false };
     if (!id || !companion?.claimDesktopDocument) return { available: false };
     const state = registry.stateFor(target);
     if (state?.companionDocumentId === id && state.companionSessionID)
@@ -422,6 +425,7 @@ else {
   };
   const claimCompanionPath = async (path, target, notificationTarget = target, options = {}) => {
     if (typeof path !== 'string' || !path) return { available: false };
+    if (isEPUBPath(path)) return { available: false };
     let id = recentIDForPath(path);
     let prepared;
     if (!id && companion?.claimDesktopDocument && recents?.prepare) {

tests/server/platform/epub-companion-claim.test.mjs

@@ -0,0 +1,53 @@
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import { readFile } from 'node:fs/promises';
+import { isEPUBPath } from '../../../electron/main/services/documents.mjs';
+
+// Exercise the composition root's real claim entry points without starting Electron.
+const source = await readFile(new URL('../../../electron/main.mjs', import.meta.url), 'utf8');
+const claims = source.slice(
+  source.indexOf('  const claimCompanionID ='),
+  source.indexOf('  const companionOwnership ='),
+);
+const createClaims = new Function(
+  'isEPUBPath',
+  'recents',
+  'companion',
+  `
+  const windows = new Map(), desktopClaimsInFlight = new Map();
+  const registry = { stateFor: () => undefined };
+  const desktopSessionID = () => 'session';
+  const handoffLockWaitMs = 30000;
+  const recentIDForPath = path => recents.path('recent') === path ? 'recent' : undefined;
+  const notifyCompanionLock = () => {};
+  ${claims}
+  return { byID: claimCompanionID, byPath: claimCompanionPath };
+`,
+);
+
+test('EPUB launch and recent opens bypass PDF-only companion claims', async () => {
+  for (const path of ['/books/new.epub', '/books/RECENT.EPUB']) {
+    const recents = { path: () => path, prepare: () => assert.fail('prepared EPUB for companion') };
+    const companion = { claimDesktopDocument: () => assert.fail('claimed EPUB as PDF') };
+    const claim = createClaims(isEPUBPath, recents, companion);
+    assert.deepEqual(await claim.byPath(path, {}), { available: false });
+    assert.deepEqual(await claim.byID('recent', {}), { available: false });
+  }
+});
+
+test('PDF opens still claim companion ownership', async () => {
+  const calls = [];
+  const claim = createClaims(
+    isEPUBPath,
+    { path: () => '/books/book.pdf' },
+    {
+      claimDesktopDocument: async (...args) => {
+        calls.push(args);
+        return { claimed: true };
+      },
+    },
+  );
+  assert.deepEqual(await claim.byPath('/books/book.pdf', {}), { claimed: true });
+  assert.equal(calls.length, 1);
+  assert.deepEqual(calls[0], ['recent', 'session', 'This Mac']);
+});