Skip to content

Support keepalives on WebSockets  #588

Description

@LukeButters

KeepAlives are a useful way of keeping open TCP connections and detecting if a TCP connection is broken, including in the case of a non graceful TCP termination. We have enabled TCP keepalives for listening and polling tentacles as described in OctopusDeploy/OctopusTentacle#692 . Doing so allows Halibut to detect failed connections allowing the caller to retry sooner and in the case of polling tentacles allows for the Polling tentacle to establish a new working connection sooner.

Currently we don't support TCP keepalives for Polling WebSockets as dicussed in this PR, we found that keep alives were only working with TCP connections, not web sockets.

Ideally we should support TCP keepalives with websocket, in this way TCP connectoons that are not gracefully terminated can be detected earlier allowing for callers to be told earlier that the RPC has failed allowing them to retry sooner.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions