Skip to content

Commit 6674bc8

Browse files
Load the trusted CI scripts from main instead of the pilot branch.
trustedCiBranch() named feature/CSTACKEX-340 for the PR-119 pilot. Return main so the presubmit uses the merged CI scripts for every pull request, and update the job guide to match. The Jenkins folder still has to switch its Remote Jenkinsfile Provider branch to main and its filter to PR-* after this merges. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
1 parent 38478ba commit 6674bc8

2 files changed

Lines changed: 14 additions & 12 deletions

File tree

‎private-cicd/Jenkinsfile‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -966,10 +966,10 @@ void abortSupersededRun() {
966966
}
967967

968968
// Branch that supplies the trusted CI scripts. It must equal the branch that
969-
// Remote Jenkinsfile Provider loads this Jenkinsfile from. PR-119 pilot value;
970-
// change it to 'main' when the folder is cut over to every pull request.
969+
// Remote Jenkinsfile Provider loads this Jenkinsfile from. Change the provider
970+
// branch in the Jenkins folder to match when this value changes.
971971
String trustedCiBranch() {
972-
return 'feature/CSTACKEX-340'
972+
return 'main'
973973
}
974974

975975
void checkoutCiScripts() {

‎private-cicd/docs/CREATE-PRESUBMIT-JOB.md‎

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,13 @@ non-draft origin pull request into `main`. Remote Jenkinsfile Provider loads
2525
`private-cicd/Jenkinsfile` from the trusted CI branch. Match branches stays off.
2626
Draft pull requests get no job. Do not add a webhook.
2727

28-
During the PR-119 pilot the trusted CI branch is `feature/CSTACKEX-340` and the
29-
folder include filter is `PR-119`. Both the Remote Jenkinsfile Provider branch
30-
and `trustedCiBranch()` in the Jenkinsfile must name that branch. Loading `main`
31-
before PR-119 is merged would run the old Jenkinsfile, which knows nothing about
32-
`CHANGE_ID` and defaults to `SOURCE_MODE=discover`. At cutover, change the
33-
provider branch and `trustedCiBranch()` to `main` and the filter to `PR-*`.
28+
The trusted CI branch is `main`. Both the Remote Jenkinsfile Provider branch and
29+
`trustedCiBranch()` in the Jenkinsfile must name that branch. During the PR-119
30+
pilot the provider branch was `feature/CSTACKEX-340` and the folder include
31+
filter was `PR-119`. Do not switch the provider branch to `main` until PR-119 is
32+
merged: the previous `main` Jenkinsfile knows nothing about `CHANGE_ID` and
33+
defaults to `SOURCE_MODE=discover`. After the merge, change the provider branch
34+
to `main` and the filter to `PR-*`, and keep `feature/CSTACKEX-340` until then.
3435

3536
The numbered sections below that create a single Pipeline job with a five-minute
3637
`SOURCE_MODE=discover` timer (11 to 16) are retired. Sections on plugins,
@@ -47,12 +48,13 @@ Open `cloudstack-ontap-presubmit-mb` > **Configure**:
4748
| --- | --- |
4849
| Branch Source | GitHub, credential `cloudstack-presubmit-github-app`, repository `NetApp/cloudstack` |
4950
| Behaviours | Discover pull requests from origin only, strategy **The current pull request revision**; remove branch and fork discovery |
50-
| Filter by name | `PR-119` for the pilot, then `PR-*` |
51-
| Build Configuration | **by Remote Jenkinsfile Provider**, repository `https://github.com/NetApp/cloudstack.git`, branch `feature/CSTACKEX-340` (pilot) then `main`, file `private-cicd/Jenkinsfile`, **Match branches off** |
51+
| Filter by name | `PR-*` (`PR-119` during the pilot) |
52+
| Build Configuration | **by Remote Jenkinsfile Provider**, repository `https://github.com/NetApp/cloudstack.git`, branch `main` (`feature/CSTACKEX-340` during the pilot), file `private-cicd/Jenkinsfile`, **Match branches off** |
5253
| Scan Repository Triggers | Periodically, 1 to 5 minutes |
5354
| Orphaned items | Keep 14 days, 50 items |
5455

55-
Run **Scan Repository Now** and expect one child, `PR-119`. The first build may
56+
Run **Scan Repository Now** and expect one child for each open non-draft pull
57+
request into `main` (only `PR-119` during the pilot). The first build may
5658
stop on Script Security. Approve only signatures requested by this Jenkinsfile
5759
and rebuild.
5860

0 commit comments

Comments
 (0)