From 406e40f2a4d109214800294f7765411dedd70c14 Mon Sep 17 00:00:00 2001 From: Umar Sabirin Date: Mon, 7 Sep 2026 14:09:30 +0700 Subject: [PATCH] fix: drop a pages check that compared against a file nobody publishes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The first pages deploy failed on the drift check added with the site, and the check was wrong on both assets it looked at. meridian.css returned 404. In marstack-cloud, -secrets and -access that file is gitignored and generated by `make site` from internal/console/assets, so no published copy exists to diff against. site.css fetched but compared unequal, because command substitution strips the trailing newline and `printf '%s'` does not put it back — a hash difference about newlines, not about content. Patching the newline would leave a step that appears to guard two stylesheets while only reaching one, so the step goes. That leaves the vendored theme unguarded, and it is worth being plain about why: this repository has to commit meridian.css because it is a CLI with no console to generate it from, and the real source is the separate marstack-theme module. Nothing checked into this repository can tell whether that module has moved on. A hash pinned here would only catch someone editing the vendored copy by hand, which is not the failure worth a CI step. --- .github/workflows/pages.yml | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml index c72d828..2a2982a 100644 --- a/.github/workflows/pages.yml +++ b/.github/workflows/pages.yml @@ -59,23 +59,6 @@ jobs: comm -23 /tmp/used /tmp/defined exit 1 - - name: Refuse a theme that has drifted from the other marstack sites - run: | - for asset in meridian.css site.css; do - remote=$(curl -sSL --fail \ - "https://raw.githubusercontent.com/MarStack-Labs/marstack-access/main/site/$asset") || { - echo "cannot read $asset from marstack-access; skipping the drift check" - continue - } - if [ "$(printf '%s' "$remote" | sha256sum | cut -d' ' -f1)" \ - != "$(sha256sum "site/$asset" | cut -d' ' -f1)" ]; then - echo "site/$asset differs from the copy marstack-access ships" - echo "this repository vendors the theme because it has no console to copy it from," - echo "so drift has to be caught here rather than by a build step" - exit 1 - fi - done - - uses: actions/configure-pages@v5 - uses: actions/upload-pages-artifact@v3 with: