From 68d5a9468e9952f928ec6d1c93069266e48e2517 Mon Sep 17 00:00:00 2001 From: Vitor Mattos Date: Mon, 21 Sep 2026 21:04:54 -0300 Subject: [PATCH 1/2] fix: render nightly release notes without shell substitution Signed-off-by: Vitor Mattos --- tests/test_nightly_release_template.py | 2 ++ workflow-templates/nightly-release.yml | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/test_nightly_release_template.py b/tests/test_nightly_release_template.py index ba9b26c..047cc2c 100644 --- a/tests/test_nightly_release_template.py +++ b/tests/test_nightly_release_template.py @@ -35,6 +35,8 @@ def test_nightly_runs_full_package_and_publication_path(self) -> None: self.assertIn("gh release create nightly", content) self.assertIn("nextcloud-libraries/nextcloud-appstore-push-action@", content) self.assertIn("nightly: true", content) + self.assertIn("printf 'Automated nightly build from \`%s\`.", content) + self.assertIn("printf 'Generated from commit \`%s\`.", content) def test_checkout_credentials_are_not_persisted(self) -> None: content = TEMPLATE.read_text(encoding="utf-8") diff --git a/workflow-templates/nightly-release.yml b/workflow-templates/nightly-release.yml index abfd431..eaa5058 100644 --- a/workflow-templates/nightly-release.yml +++ b/workflow-templates/nightly-release.yml @@ -251,7 +251,7 @@ jobs: { echo "## 🌙 Nightly Build - ${APP_VERSION}" echo - echo "Automated nightly build from `${NIGHTLY_BRANCH}`." + printf 'Automated nightly build from `%s`.\\n' "${NIGHTLY_BRANCH}" echo echo "⚠️ **Development version** - may contain bugs or unstable features." echo @@ -260,7 +260,7 @@ jobs: printf '%s\n' "${commits}" echo echo "---" - echo "Generated from commit `${GITHUB_SHA:0:7}`." + printf 'Generated from commit `%s`.\\n' "${GITHUB_SHA:0:7}" } > release-notes.md - name: Create or update GitHub release From ae5bd1a3ca7efb6d8f23b1205a79f12ae1ef9e22 Mon Sep 17 00:00:00 2001 From: Vitor Mattos Date: Mon, 21 Sep 2026 21:06:24 -0300 Subject: [PATCH 2/2] test: assert literal nightly Markdown backticks Signed-off-by: Vitor Mattos --- tests/test_nightly_release_template.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_nightly_release_template.py b/tests/test_nightly_release_template.py index 047cc2c..c603aea 100644 --- a/tests/test_nightly_release_template.py +++ b/tests/test_nightly_release_template.py @@ -35,8 +35,8 @@ def test_nightly_runs_full_package_and_publication_path(self) -> None: self.assertIn("gh release create nightly", content) self.assertIn("nextcloud-libraries/nextcloud-appstore-push-action@", content) self.assertIn("nightly: true", content) - self.assertIn("printf 'Automated nightly build from \`%s\`.", content) - self.assertIn("printf 'Generated from commit \`%s\`.", content) + self.assertIn("printf 'Automated nightly build from `%s`.", content) + self.assertIn("printf 'Generated from commit `%s`.", content) def test_checkout_credentials_are_not_persisted(self) -> None: content = TEMPLATE.read_text(encoding="utf-8")