From 352df98b282a471efff08327150b47160b35a22a Mon Sep 17 00:00:00 2001 From: Jarry Shaw Date: Fri, 9 Oct 2026 14:44:12 -0400 Subject: [PATCH] docs(sctp): a parsed Host Name may lack its null terminator #1483 made a captured Host Name without a NUL rebuild as captured, but the schema field comment still said the name always includes one, and the data comment read as a contradiction. Both now say the name is as captured. --- pcapkit/protocols/data/transport/sctp.py | 2 +- pcapkit/protocols/schema/transport/sctp.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/pcapkit/protocols/data/transport/sctp.py b/pcapkit/protocols/data/transport/sctp.py index 1b1c47f475..aeacc4aaa6 100644 --- a/pcapkit/protocols/data/transport/sctp.py +++ b/pcapkit/protocols/data/transport/sctp.py @@ -360,7 +360,7 @@ def __init__(self, type: 'ParameterType', length: 'int', increment: 'int') -> 'N class HostNameAddressParameter(Parameter): """Data model for SCTP host name address parameter.""" - #: Host name as captured, null terminator included; a parsed name may lack one. + #: Host name as captured, with any null terminator; a parsed name may lack one. name: 'bytes' if TYPE_CHECKING: diff --git a/pcapkit/protocols/schema/transport/sctp.py b/pcapkit/protocols/schema/transport/sctp.py index 7d17478449..b2143da213 100644 --- a/pcapkit/protocols/schema/transport/sctp.py +++ b/pcapkit/protocols/schema/transport/sctp.py @@ -593,7 +593,8 @@ def __init__(self, type: 'Enum_Parameter', length: 'int', increment: 'int') -> ' class HostNameAddressParameter(Parameter, code=Enum_Parameter.Host_Name_Address): """Header schema for SCTP host name address parameter.""" - #: Host name, including at least one null terminator. + #: Host name as captured. :rfc:`9260#section-3.3.2.1.4` asks for at least one + #: null terminator, but a parsed name may lack it. name: 'bytes' = BytesField(length=lambda pkt: max(pkt['length'] - 4, 0)) #: Padding. padding: 'bytes' = PaddingField(length=padding_length)