fix(verify): require live sources for green promotion

Author: Seungpyo1007

app/verify/cli.py

@@ -632,13 +632,13 @@ def cmd_pr(args: argparse.Namespace) -> int:
 
         # Tier 2 — external cross-reference (network, exact-heading only).
         fetcher = crossref.WikidataFetcher()
-        xref: dict[str, str] = {}
+        xref: dict[tuple[str, str], str] = {}
         decisions: Counter[str] = Counter()
         for r, _ in scored:
             try:
                 xres = crossref.crossref_record(r.data, fetcher)
                 if r.slug:
-                    xref[r.slug] = xres.decision
+                    xref[(r.category, r.slug)] = xres.decision
                 decisions[xres.decision] += 1
             except Exception:
                 decisions["error"] += 1
@@ -655,8 +655,12 @@ def cmd_pr(args: argparse.Namespace) -> int:
         hold = 0
         for r, s in scored:
             urls_r = [u for u in r.data.get("source_urls", []) if isinstance(u, str)]
-            dec = promote.decide(band=s.band, source_urls=urls_r, url_cache=url_cache,
-                                 crossref_decision=xref.get(r.slug) if r.slug else None)
+            dec = promote.decide(
+                band=s.band,
+                source_urls=urls_r,
+                url_cache=url_cache,
+                crossref_decision=xref.get((r.category, r.slug)) if r.slug else None,
+            )
             if dec.promote:
                 promote_rows.append((r, dec.reason))
             else:

app/verify/promote.py

@@ -66,14 +66,10 @@ def decide(
     # Reality confirm: external source agrees -> strongest promotion.
     if crossref_decision == "confirm":
         return PromotionDecision(True, "crossref-confirm")
-    # green = passed the offline inspection: an authoritative source (T1/T2) IS
-    # cited, cross-field consistency holds, the record is complete, and there are
-    # no hard violations. That is the verification result, so promote it (unless
-    # crossref contradicted above). The earlier live-HTTP source re-check was
-    # dropped: most green records cite spec DBs (phonedb/cpubenchmark) that block
-    # automated requests, which kept verified stuck far below the green band.
-    if band == "green":
-        return PromotionDecision(True, "green")
+    # green is only an offline candidate. Promotion still requires a cited
+    # authoritative source to have been confirmed alive by Tier 1.
+    if band == "green" and has_live_authoritative_source(source_urls, url_cache):
+        return PromotionDecision(True, "green-live-source")
     return PromotionDecision(False, "needs-confirmation")
 
 

tests/verify/test_promote_crossref.py

@@ -113,21 +113,32 @@ def test_write_back_atomic_lf_preserved():
 # --- promotion decision ----------------------------------------------------------
 
 
-def test_green_promotes():
-    # green = passed the offline inspection -> verified. The live-source state no
-    # longer gates (green already requires a cited authoritative source).
-    d = promote.decide(band="green", source_urls=[], url_cache={}, crossref_decision=None)
-    assert d.promote and d.reason == "green"
+def test_green_requires_live_authoritative_source():
+    d = promote.decide(
+        band="green",
+        source_urls=["https://www.intel.com/x"],
+        url_cache={},
+        crossref_decision=None,
+    )
+    assert not d.promote
+
+
+def test_green_promotes_with_live_authoritative_source():
+    cache = {"https://www.phonedb.net/x": {"alive": True}}
+    d = promote.decide(
+        band="green", source_urls=["https://www.phonedb.net/x"],
+        url_cache=cache, crossref_decision=None,
+    )
+    assert d.promote and d.reason == "green-live-source"
 
 
-def test_green_promotes_regardless_of_source_liveness():
-    # Even with a dead / unchecked source, a green record promotes.
+def test_green_does_not_promote_with_dead_authoritative_source():
     cache = {"https://www.phonedb.net/x": {"alive": False}}
     d = promote.decide(
         band="green", source_urls=["https://www.phonedb.net/x"],
         url_cache=cache, crossref_decision=None,
     )
-    assert d.promote and d.reason == "green"
+    assert not d.promote
 
 
 def test_yellow_without_confirm_holds():