Skip to content

Commit 896bbf8

Browse files
committed
fix(data): resolve 170 more smartphone brand-prefix conflicts
Continues the brand-prefix dedup from #329/#330. Those resolved 414 pairs and carried forward a residual of 353. This resolves 170 of that residual, source- verified, and explicitly un-pairs 3 that are genuinely different devices. Three sub-slices resolved (Refs #296): 1. 37 vendor/Wikipedia-sourced same-chip pairs. Same device, same physical chip (soc slugs differ only in spelling, e.g. `qualcomm-msm8974-snapdragon-800` vs `snapdragon-800`, `hisilicon-kirin-980` vs `kirin-980`), with battery/weight/ram already matching. Unlike the phonedb twins in #330, the twin here carries a Wikipedia or vendor page as its source, so its specific release_date is reliable and was adopted over the bare side's generic YYYY-01-01 placeholder (spot-checked: Huawei P30 Pro 2019-03-26 = GSMArena; LG G2 September 2013 = Wikipedia). Kept the canonical bare slug, unioned source_urls, set verified=true only where the twin was a vendor/Wikipedia source. 2. 7 same-model pairs whose two sides named different chips — verified against a cited source which side is correct, fixed the soc, then merged: - Oppo Find X8 Pro -> Dimensity 9400 (oppo.com launch; GSMArena) - Motorola Edge 50 Ultra -> Snapdragon 8s Gen 3 (motorola.com; phonearena) - Honor Magic V3 -> Snapdragon 8 Gen 3 (phonearena SM8650-AB; honor.com) - OnePlus Nord CE 2 Lite (Snapdragon 695), Nord CE 2 (Dimensity 900), Sony Xperia Z (APQ8064 S4 Pro), Honor Magic V2 (Snapdragon 8 Gen 2) — the bare side already held the correct chip; merged and cited GSMArena/vendor. 3. 126 pairs where the soc slugs are the same physical chip via a spelling variant, or one side's soc was a vague descriptor (`dual-core 1.0 GHz`, `<brand> mobile platform`, `n-a`) and the twin named the specific FK-valid part. Kept the GSMArena (bare) record, adopted the specific soc when the keeper's was vague, rejected the phonedb stamped placeholders (weight 150.0 / battery 1500), left the (unreliable) phonedb dates alone, unioned source_urls, deleted the twin. Un-paired as genuinely different devices (left as separate records, no merge): - HTC: `one-m9` holds the One M9+ (Helio X10) vs the One M9 (Snapdragon 810). - Motorola: `razr` holds the 2023 Razr (SD 8+ Gen 1) vs the 2019 Razr (SD 710). - Sony: `xperia-z3` holds the Xperia Z3+ (SD 810) vs the Xperia Z3 (SD 801). No value invented; every repaired field cites its evidence URL in source_urls. Left unresolved for a later pass (documented on #296): 21 same-model pairs whose correct chip I could not source this round (includes the Huawei P50 Pro, which genuinely shipped both Kirin 9000 and Snapdragon 888 SKUs), 157 pairs needing a per-record ram/weight/battery source, and 2 odd/other pairs. Both gates pass: `python -m app.validate` and `integrity_check.py <data> --strict` (0 hard anomalies). Refs #296
1 parent cddc52e commit 896bbf8

340 files changed

Lines changed: 731 additions & 5376 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎data/smartphone/acer/2010/acer-betouch-e110.json‎

Lines changed: 0 additions & 22 deletions
This file was deleted.

‎data/smartphone/acer/2010/betouch-e110.json‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"slug": "betouch-e110",
33
"base_model_slug": "betouch-e110",
4-
"name": "beTouch E110",
4+
"name": "Acer beTouch E110",
55
"brand": "acer",
66
"soc": "st-ericsson-pnx6715-416mhz",
77
"release_date": "2010-01-01",
@@ -11,7 +11,8 @@
1111
"os": "Android",
1212
"verified": false,
1313
"source_urls": [
14-
"https://www.kaggle.com/datasets/msainani/gsmarena-mobile-devices"
14+
"https://www.kaggle.com/datasets/msainani/gsmarena-mobile-devices",
15+
"https://phonedb.net/index.php?m=device&id=2230"
1516
],
1617
"display": {
1718
"size_inch": 2.8,

‎data/smartphone/amoi/2007/amoi-e76.json‎

Lines changed: 0 additions & 22 deletions
This file was deleted.

‎data/smartphone/amoi/2007/amoi-e78.json‎

Lines changed: 0 additions & 22 deletions
This file was deleted.

‎data/smartphone/amoi/2007/e76.json‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
{
22
"slug": "e76",
33
"base_model_slug": "e76",
4-
"name": "E76",
4+
"name": "Amoi E76",
55
"brand": "amoi",
6-
"soc": "amoi-mobile-platform-2007",
6+
"soc": "texas-instruments-omap-1710",
77
"release_date": "2007-01-01",
88
"ram_gb": 1,
99
"battery_mah": 1100,
10-
"weight_g": 150.0,
10+
"weight_g": 95.0,
1111
"os": "Windows Mobile",
1212
"verified": false,
1313
"source_urls": [
14-
"https://www.kaggle.com/datasets/msainani/gsmarena-mobile-devices"
14+
"https://www.kaggle.com/datasets/msainani/gsmarena-mobile-devices",
15+
"https://phonedb.net/index.php?m=device&id=795"
1516
],
1617
"display": {
1718
"size_inch": 2.2,

‎data/smartphone/amoi/2007/e78.json‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
{
22
"slug": "e78",
33
"base_model_slug": "e78",
4-
"name": "E78",
4+
"name": "Amoi E78",
55
"brand": "amoi",
6-
"soc": "amoi-mobile-platform-2007",
6+
"soc": "texas-instruments-omap-v1030",
77
"release_date": "2007-01-01",
88
"ram_gb": 1,
99
"battery_mah": 1100,
10-
"weight_g": 150.0,
10+
"weight_g": 125.0,
1111
"os": "Windows Mobile",
1212
"verified": false,
1313
"source_urls": [
14-
"https://www.kaggle.com/datasets/msainani/gsmarena-mobile-devices"
14+
"https://www.kaggle.com/datasets/msainani/gsmarena-mobile-devices",
15+
"https://phonedb.net/index.php?m=device&id=796"
1516
],
1617
"display": {
1718
"size_inch": 2.46,

‎data/smartphone/asus/2006/asus-p525.json‎

Lines changed: 0 additions & 22 deletions
This file was deleted.

‎data/smartphone/asus/2006/p525.json‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
{
22
"slug": "p525",
33
"base_model_slug": "p525",
4-
"name": "P525",
4+
"name": "Asus P525",
55
"brand": "asus",
6-
"soc": "intel-xscale-416-mhz",
6+
"soc": "intel-xscale-pxa270",
77
"release_date": "2006-01-01",
88
"ram_gb": 1,
99
"battery_mah": 1300,
1010
"weight_g": 160.0,
1111
"os": "Windows Mobile",
1212
"verified": false,
1313
"source_urls": [
14-
"https://www.kaggle.com/datasets/msainani/gsmarena-mobile-devices"
14+
"https://www.kaggle.com/datasets/msainani/gsmarena-mobile-devices",
15+
"https://phonedb.net/index.php?m=device&id=463"
1516
],
1617
"display": {
1718
"size_inch": 2.8,

‎data/smartphone/asus/2006/p535.json‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
22
"slug": "p535",
33
"base_model_slug": "p535",
4-
"name": "P535",
4+
"name": "Asus P535",
55
"brand": "asus",
6-
"soc": "intel-xscale-520-mhz",
6+
"soc": "intel-xscale-pxa270",
77
"release_date": "2006-01-01",
88
"ram_gb": 1,
99
"battery_mah": 1300,
@@ -12,7 +12,8 @@
1212
"verified": true,
1313
"source_urls": [
1414
"https://www.kaggle.com/datasets/msainani/gsmarena-mobile-devices",
15-
"https://en.wikipedia.org/wiki/Asus_P535"
15+
"https://en.wikipedia.org/wiki/Asus_P535",
16+
"https://phonedb.net/index.php?m=device&id=635"
1617
],
1718
"display": {
1819
"size_inch": 2.8,

‎data/smartphone/asus/2007/asus-p535.json‎

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)