Skip to content

Commit 7ce54ef

Browse files
committed
ci: send the PR base to TechEngine checks and stop tracking scores.jsonl
TechEngine #95 diffs against the PR's real base instead of a hard-coded origin/develop (release PRs reported no changes) or origin/main (develop PRs over-counted). Pass base_ref/base_sha from the validation relay, verify-report and /verify. scores.jsonl is a 43 MB generated cache that TechEngine no longer reads from git; untrack and ignore it. Refs #1
1 parent a9addb5 commit 7ce54ef

5 files changed

Lines changed: 11 additions & 105800 deletions

File tree

‎.github/workflows/request-engine-pr-validation.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ jobs:
4040
PR_NUMBER: ${{ github.event.pull_request.number || inputs.pr_number }}
4141
HEAD_SHA: ${{ github.event.pull_request.head.sha || inputs.head_sha }}
4242
HEAD_REF: ${{ github.event.pull_request.head.ref || '' }}
43+
BASE_REF: ${{ github.event.pull_request.base.ref || '' }}
44+
BASE_SHA: ${{ github.event.pull_request.base.sha || '' }}
4345
PR_URL: ${{ github.event.pull_request.html_url || '' }}
4446
steps:
4547
- name: Skip when ENGINE_TOKEN is unset
@@ -60,6 +62,8 @@ jobs:
6062
pr_number: process.env.PR_NUMBER,
6163
head_sha: process.env.HEAD_SHA,
6264
head_ref: process.env.HEAD_REF,
65+
base_ref: process.env.BASE_REF,
66+
base_sha: process.env.BASE_SHA,
6367
pr_url: process.env.PR_URL,
6468
requested_by: context.actor
6569
}

‎.github/workflows/verify-command.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ jobs:
5050
client_payload: {
5151
pr_number: String(issue_number),
5252
head_sha: pr.data.head.sha,
53+
base_ref: pr.data.base.ref,
54+
base_sha: pr.data.base.sha,
5355
comment_id: context.payload.comment.id,
5456
requested_by: context.payload.comment.user.login,
5557
},

‎.github/workflows/verify-report.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ jobs:
4444
client_payload: {
4545
pr_number: String(context.payload.pull_request.number),
4646
head_sha: context.payload.pull_request.head.sha,
47+
base_ref: context.payload.pull_request.base.ref,
48+
base_sha: context.payload.pull_request.base.sha,
4749
mode: 'tier0',
4850
requested_by: context.payload.pull_request.user.login,
4951
},

‎.gitignore‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,6 @@ coverage.xml
4646
.vscode/
4747
.DS_Store
4848

49+
50+
# Generated by app.verify score runs; rebuilt on demand, too large to track (43 MB).
51+
/data/_verify/state/scores.jsonl

0 commit comments

Comments
 (0)