From 4c9f790994ee12c32f3fe620c98f1b7cb6f1fc2f Mon Sep 17 00:00:00 2001 From: Nick O'Leary Date: Wed, 2 Sep 2026 10:14:19 +0100 Subject: [PATCH 1/2] Only show top-banner if no left-banner set --- frontend/src/pages/account/Create.vue | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/frontend/src/pages/account/Create.vue b/frontend/src/pages/account/Create.vue index 8a7e96526f..e5c835cbb3 100644 --- a/frontend/src/pages/account/Create.vue +++ b/frontend/src/pages/account/Create.vue @@ -7,7 +7,7 @@

Date: Wed, 2 Sep 2026 10:54:35 +0100 Subject: [PATCH 2/2] Update tests for sign-up page banner logic --- test/e2e/frontend/cypress/tests/admin.spec.js | 54 ++++++++++++++++++- 1 file changed, 52 insertions(+), 2 deletions(-) diff --git a/test/e2e/frontend/cypress/tests/admin.spec.js b/test/e2e/frontend/cypress/tests/admin.spec.js index 3dd484d831..23b0cbc0e2 100644 --- a/test/e2e/frontend/cypress/tests/admin.spec.js +++ b/test/e2e/frontend/cypress/tests/admin.spec.js @@ -166,14 +166,36 @@ describe('FlowFuse platform admin users', () => { cy.get('[data-el="splash"]').should('not.exist') }) - it('can customise the content of the "Sign Up" screen', () => { + it('can customise the content of the "Sign Up" screen - splash only', () => { cy.intercept('GET', '/api/*/settings').as('getSettings') cy.visit('/admin/settings/general') cy.wait('@getSettings') - cy.get('[data-el="banner"]').type('this is banner') cy.get('[data-el="splash"]').type('

Welcome to FlowFuse

') + cy.get('[data-el="banner"]').clear() + + cy.get('[data-action="save-settings"]').click() + + cy.logout() + + cy.visit('/') + + cy.get('[data-action="sign-up"]').click() + + cy.url().should('include', '/account/create') + + cy.get('[data-el="banner-text"]').should('not.exist') + cy.get('[data-el="splash"]').contains('Welcome to FlowFuse') + }) + it('can customise the content of the "Sign Up" screen - banner only', () => { + cy.intercept('GET', '/api/*/settings').as('getSettings') + + cy.visit('/admin/settings/general') + cy.wait('@getSettings') + + cy.get('[data-el="splash"]').clear() + cy.get('[data-el="banner"]').type('this is banner') cy.get('[data-action="save-settings"]').click() @@ -186,7 +208,35 @@ describe('FlowFuse platform admin users', () => { cy.url().should('include', '/account/create') cy.get('[data-el="banner-text"]').contains('this is banner') + cy.get('[data-el="splash"]').should('not.exist') + }) + it('can customise the content of the "Sign Up" screen - splash and banner', () => { + cy.intercept('GET', '/api/*/settings').as('getSettings') + + cy.visit('/admin/settings/general') + cy.wait('@getSettings') + + cy.get('[data-el="banner"]').type('this is banner') + cy.get('[data-el="splash"]').type('

Welcome to FlowFuse

') + + cy.get('[data-action="save-settings"]').click() + + cy.logout() + + cy.visit('/') + + cy.get('[data-action="sign-up"]').click() + + cy.url().should('include', '/account/create') + + // For the regular page, with both configured, only the splash should be shown + cy.get('[data-el="banner-text"]').should('not.exist') cy.get('[data-el="splash"]').contains('Welcome to FlowFuse') + + // For the popup, with both configured, only the banner should be shown + cy.visit('/account/create?context=popup') + cy.get('[data-el="banner-text"]').contains('this is banner') + cy.get('[data-el="splash"]').should('not.exist') }) }) })