Skip to content

[C5] Bare ruff config + non-strict mypy + monolithic blanket silence #295

Description

@DsThakurRawat

Labels: ci, tooling, priority:medium
File: pyproject.toml:323-325 (ruff: only target-version + line-length, no select), :327-336 (mypy check_untyped_defs=false, ignore_missing_imports=true, follow_imports=silent), :338-346 (blanket disable of 5 codes for tether.exporters.monolithic). Src has 107 # type: ignore, 255 # noqa.

Description. Ruff runs only default E/F (no I/B/UP/SIM). mypy never checks untyped function bodies (the majority here) and silences imports. The single most error-prone export path (monolithic, the cos=1.0 shipped path) has type checking effectively off.

Tasks.

  • Add an explicit ruff select (≥ E,F,I,B,UP,SIM).
  • Enable check_untyped_defs=true (fix/ignore fallout incrementally).
  • Replace the monolithic blanket disable with targeted per-line ignores.

Dedup. Complements C1 (C1 = run it in CI; C5 = make it strict enough to matter). Not covered.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions