Why not centralize Phoebus module versions in parent pom ?

[flef]

Hi,

It seems that all the modules have similar life cycles (a new module version is released for each Phoebus version).
I'm wondering if there is a reason to have not centralized phoebus sub-modules version in parent pom ?

For instance, instead of having

<dependency>
      <groupId>org.phoebus</groupId>
      <artifactId>core-framework</artifactId>
      <version>5.0.3-SNAPSHOT</version>
</dependency>

We can put a variable ${phoebus.version} defined as follow in the parent pom :

<properties>
    <phoebus.version>5.0.3-SNAPSHOT</phoebus.version>
</properties>

And used as follow everywhere :

<dependency>
      <groupId>org.phoebus</groupId>
      <artifactId>core-framework</artifactId>
      <version>${phoebus.version}</version>
</dependency>

Are there any constraints related to the build process or other factors that explain this choice?

Regards,
Florian.

[kasemir]

I was wondering myself, and I have no clue about maven, really, but I think the idea is to use some maven-release-tool that patches all the pom files.

[georgweiss]

@kasemir, that is correct. The release plugin edits the pom files, though I have to admit I have not run the release cycle using a property.

[shroffk]

Kay is correct
Right now this is mainly about ensuring that the automatic releases plugin handles the updating of the versions.

Also,
Technically...we could have different life cycle for the applications and we can also create a product with different versions of apps

[kasemir]

Again, failing to understand the divine advantages of maven, I think I would like a ${phoebus.version} definition in the parent pom because that way I can use <version>${phoebus.version}</version> in the SNS product. Right now I have 5.0.3-SNAPSHOT in there. With every "release", I then wonder 2 weeks later why the nightly SNS build failed to pickup what's new on the main branch until I update the SNS pom to the next xxxx-SNAPSHOT

[jacomago]

Note I would go further and use something like https://github.com/qoomon/maven-git-versioning-extension or https://github.com/ccampo133/maven-git-version

Makes it super nice that the version comes from the git tag and you don't need multiple PRs to change version every time.