From 4cf0ab3a39cf88edd39d9acd78617f9127b216a9 Mon Sep 17 00:00:00 2001 From: Warren Lee <5959690+wrn14897@users.noreply.github.com> Date: Mon, 24 Aug 2026 10:32:49 -0700 Subject: [PATCH 1/2] chore: bump js-yaml to ^5.3.0 --- package.json | 2 +- yarn.lock | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 7e0e64fd..2ebefe6f 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ }, "dependencies": { "@changesets/cli": "^2.29.4", - "js-yaml": "^4.2.0" + "js-yaml": "^5.3.0" }, "packageManager": "yarn@4.9.2" } diff --git a/yarn.lock b/yarn.lock index c9098335..ede1d3c2 100644 --- a/yarn.lock +++ b/yarn.lock @@ -329,6 +329,13 @@ __metadata: languageName: node linkType: hard +"argparse@npm:^2.0.1": + version: 2.0.1 + resolution: "argparse@npm:2.0.1" + checksum: 10c0/c5640c2d89045371c7cedd6a70212a04e360fd34d6edeae32f6952c63949e3525ea77dbec0289d8213a99bbaeab5abfa860b5c12cf88a2e6cf8106e90dd27a7e + languageName: node + linkType: hard + "array-union@npm:^2.1.0": version: 2.1.0 resolution: "array-union@npm:2.1.0" @@ -531,6 +538,7 @@ __metadata: resolution: "helm-charts@workspace:." dependencies: "@changesets/cli": "npm:^2.29.4" + js-yaml: "npm:^5.3.0" languageName: unknown linkType: soft @@ -617,6 +625,17 @@ __metadata: languageName: node linkType: hard +"js-yaml@npm:^5.3.0": + version: 5.3.0 + resolution: "js-yaml@npm:5.3.0" + dependencies: + argparse: "npm:^2.0.1" + bin: + js-yaml: bin/js-yaml.mjs + checksum: 10c0/c67383a74026f3b550fe1131c6f0f56df11e227fc9b8b8c1c85154f106831a95a944f2dd4f505498d537790483aec7cd5e3d5e9913fe28fa2d131eeb894a0fd9 + languageName: node + linkType: hard + "jsonfile@npm:^4.0.0": version: 4.0.0 resolution: "jsonfile@npm:4.0.0" From 0b6e1b90499b57222f27fdd9abd2f5795ab968e7 Mon Sep 17 00:00:00 2001 From: Warren Lee <5959690+wrn14897@users.noreply.github.com> Date: Mon, 24 Aug 2026 11:56:21 -0700 Subject: [PATCH 2/2] ci: smoke-test update-chart-versions.js at PR time --- .github/workflows/helm-test.yaml | 38 ++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/.github/workflows/helm-test.yaml b/.github/workflows/helm-test.yaml index 48bdd804..2a8f0ec6 100644 --- a/.github/workflows/helm-test.yaml +++ b/.github/workflows/helm-test.yaml @@ -9,6 +9,44 @@ on: branches: [ main ] jobs: + version-script-smoke: + # The update-chart-versions.js script otherwise only runs post-merge in + # release.yml; exercise it at PR time so dependency bumps (e.g. js-yaml) + # can't break chart releases silently. + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Setup Node.js 20 + uses: actions/setup-node@v3 + with: + node-version: 20 + + - name: Enable Corepack + run: corepack enable + + - name: Install Dependencies + run: yarn + + - name: Run update-chart-versions script + run: | + node scripts/update-chart-versions.js + # Verify the yaml round-trip produced a valid Chart.yaml with the + # version from package.json. + node -e ' + const fs = require("fs"); + const yaml = require("js-yaml"); + const { version } = require("./package.json"); + const chart = yaml.load(fs.readFileSync("charts/clickstack/Chart.yaml", "utf8")); + if (chart.version !== version) { + console.error(`Chart.yaml version ${chart.version} != package.json version ${version}`); + process.exit(1); + } + console.log(`Chart.yaml round-trip OK (version ${chart.version})`); + ' + git checkout -- charts/*/Chart.yaml + helm-unittest: runs-on: ubuntu-latest steps: