From 59d52a967f0be91b97283723652af5ce837d9b29 Mon Sep 17 00:00:00 2001 From: Saqib Date: Fri, 11 Sep 2026 18:08:29 +0530 Subject: [PATCH] fix: point prod smoke tests at prod and skip provider-smoke there The Smoke Tests job passed the repo-level HOME_URL_DEV (the dev site) on main too, so every prod deploy's consumer and provider suites tested dev: prod's nginx logged 0 test-browser requests during a prod run's smoke window, dev's logged 8840. Prod rollbacks were being triggered by dev timeouts, and prod's UI was never actually tested. On main, pass the prod URL and set skip_provider, since provider-smoke creates content with the test account. --- .github/workflows/deploy-backend.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deploy-backend.yml b/.github/workflows/deploy-backend.yml index 300e584..0a67128 100644 --- a/.github/workflows/deploy-backend.yml +++ b/.github/workflows/deploy-backend.yml @@ -259,8 +259,15 @@ jobs: # force_smoke_failure test path. deployed_sha: ${{ (inputs.force_smoke_failure == true && 'forced-failure-sentinel') || github.sha }} min_passed: ${{ inputs.force_smoke_failure && 999 || 1 }} + # provider-smoke creates datasets/use cases with the test account, so + # prod deploys run only the read-only api and consumer suites. + skip_provider: ${{ github.ref_name == 'main' }} secrets: - HOME_URL_DEV: ${{ secrets.HOME_URL_DEV }} + # This job can't see environment-scoped secrets, and the repo-level + # HOME_URL_DEV is the dev site -- passing it on main smoke-tested dev + # while gating a prod deploy. Literal, not a secret, so a missing value + # can't silently fall back to dev through the `&& ||` idiom. + HOME_URL_DEV: ${{ github.ref_name == 'main' && 'https://civicdataspace.in' || secrets.HOME_URL_DEV }} TEST_EMAIL_1: ${{ secrets.TEST_EMAIL_1 }} TEST_PASSWORD_1: ${{ secrets.TEST_PASSWORD_1 }} TEST_EMAIL_2: ${{ secrets.TEST_EMAIL_2 }}