|
2 | 2 |
|
3 | 3 | import static org.junit.jupiter.api.Assertions.*; |
4 | 4 | import static org.junit.jupiter.api.Assumptions.assumeTrue; |
| 5 | +import static org.mockito.Mockito.*; |
| 6 | +import static org.mockito.ArgumentMatchers.argThat; |
5 | 7 |
|
6 | 8 | import java.io.ByteArrayInputStream; |
7 | 9 | import java.io.IOException; |
|
20 | 22 | import org.junit.jupiter.api.io.TempDir; |
21 | 23 |
|
22 | 24 | import com.bencodez.simpleapi.core.config.YamlConfiguration; |
| 25 | +import com.google.common.jimfs.Configuration; |
| 26 | +import com.google.common.jimfs.Jimfs; |
23 | 27 |
|
24 | 28 | class YamlConfigurationTest { |
25 | 29 | @TempDir Path directory; |
@@ -197,6 +201,54 @@ private static Integer initialize(Path path, String text, CyclicBarrier gate) th |
197 | 201 | catch (IOException stale) { return null; } |
198 | 202 | } |
199 | 203 |
|
| 204 | + @Test void caseAliasTargetsOnCaseInsensitiveStoreCannotLoseConcurrentEdits() throws Exception { |
| 205 | + var workers = Executors.newFixedThreadPool(2); |
| 206 | + try (var filesystem = Jimfs.newFileSystem(Configuration.osX().toBuilder() |
| 207 | + .setPathEqualityUsesCanonicalForm(false).build())) { |
| 208 | + Path parent = filesystem.getPath("/config"); |
| 209 | + Files.createDirectory(parent); |
| 210 | + for (int trial = 0; trial < 50; trial++) { |
| 211 | + Path firstPath = parent.resolve("Settings-" + trial + ".yml"); |
| 212 | + Path secondPath = parent.resolve("settings-" + trial + ".yml"); |
| 213 | + Files.writeString(firstPath, "First: 0\nSecond: 0\n"); |
| 214 | + assertNotEquals(firstPath, secondPath, "Paths must retain spelling-sensitive equality"); |
| 215 | + assertNotEquals(firstPath.hashCode(), secondPath.hashCode()); |
| 216 | + assertTrue(Files.isSameFile(firstPath, secondPath), "Store must resolve case aliases"); |
| 217 | + var first = YamlConfiguration.load(firstPath); |
| 218 | + var second = YamlConfiguration.load(secondPath); |
| 219 | + var gate = new CyclicBarrier(2); |
| 220 | + var one = workers.submit(() -> editAtBarrier(first, "First", gate)); |
| 221 | + var two = workers.submit(() -> editAtBarrier(second, "Second", gate)); |
| 222 | + boolean firstSucceeded = one.get(10, TimeUnit.SECONDS); |
| 223 | + boolean secondSucceeded = two.get(10, TimeUnit.SECONDS); |
| 224 | + assertNotEquals(firstSucceeded, secondSucceeded, "Case aliases must share revision coordination"); |
| 225 | + var disk = YamlConfiguration.load(firstPath); |
| 226 | + assertEquals(firstSucceeded ? 1 : 0, disk.getInt("First")); |
| 227 | + assertEquals(secondSucceeded ? 1 : 0, disk.getInt("Second")); |
| 228 | + } |
| 229 | + } finally { |
| 230 | + workers.shutdownNow(); |
| 231 | + assertTrue(workers.awaitTermination(5, TimeUnit.SECONDS)); |
| 232 | + } |
| 233 | + } |
| 234 | + |
| 235 | + @Test void committedResourceInitializationRemainsSuccessfulAfterUnlinkFailure() throws Exception { |
| 236 | + try (var files = mockStatic(Files.class, CALLS_REAL_METHODS)) { |
| 237 | + files.when(() -> Files.deleteIfExists(argThat((Path staged) -> staged != null |
| 238 | + && staged.getFileName().toString().startsWith(".simpleapi-config-")))) |
| 239 | + .thenThrow(new IOException("synthetic staged unlink failure")); |
| 240 | + var config = YamlConfiguration.load(path(), new TrackedStream("Points: 7\n")); |
| 241 | + assertEquals(7, config.getInt("Points")); |
| 242 | + assertEquals(config.snapshot().revision(), YamlConfiguration.load(path()).snapshot().revision()); |
| 243 | + assertEquals("Points: 7\n", Files.readString(path())); |
| 244 | + } |
| 245 | + try (var children = Files.list(directory)) { |
| 246 | + var staged = children.filter(file -> file.getFileName().toString().startsWith(".simpleapi-config-")).toList(); |
| 247 | + assertEquals(1, staged.size(), "Injected cleanup failure should leave exactly its staged sibling"); |
| 248 | + for (Path file : staged) Files.delete(file); |
| 249 | + } |
| 250 | + } |
| 251 | + |
200 | 252 | private static boolean editAtBarrier(YamlConfiguration config, String key, CyclicBarrier gate) throws Exception { |
201 | 253 | try { |
202 | 254 | config.update(edit -> { |
|
0 commit comments