update

Author: linglingye001

test/integration/featureFlag.test.ts

@@ -6,7 +6,7 @@ import { assert } from "chai";
 import { DefaultAzureCredential } from "@azure/identity";
 import { load } from "../../src/index.js";
 import type { AzureAppConfiguration } from "../../src/index.js";
-import { createNotModifiedResponseTracker, getIntegrationTestEndpoint, IntegrationTestContext, REFRESH_INTERVAL_IN_MS, refreshUntil } from "./helpers.js";
+import { createNotModifiedResponseTracker, INTEGRATION_TEST_ENDPOINT as endpoint, IntegrationTestContext, REFRESH_INTERVAL_IN_MS, refreshUntil } from "./helpers.js";
 
 interface FeatureFlag {
     id: string;
@@ -28,12 +28,10 @@ function getFeatureFlags(settings: AzureAppConfiguration): FeatureFlag[] {
 }
 
 describe("integration: feature flags", function () {
-    let endpoint: string;
     let credential: DefaultAzureCredential;
     let context: IntegrationTestContext;
 
     before(() => {
-        endpoint = getIntegrationTestEndpoint();
         credential = new DefaultAzureCredential();
     });
 

test/integration/helpers.ts

@@ -8,28 +8,10 @@ import type { PipelinePolicy } from "@azure/core-rest-pipeline";
 import type { TokenCredential } from "@azure/identity";
 import type { AzureAppConfiguration } from "../../src/index.js";
 
+export const INTEGRATION_TEST_ENDPOINT = "https://appconfig-jsprovider-integrationtest.azconfig.io";
 export const REFRESH_INTERVAL_IN_MS = 1_000;
 const REFRESH_TIMEOUT_IN_MS = 30_000;
 
-export function getIntegrationTestEndpoint(): string {
-    const endpoint = process.env.AZ_CONFIG_ENDPOINT?.trim();
-    if (!endpoint) {
-        throw new Error("Set AZ_CONFIG_ENDPOINT to an App Configuration test-store endpoint before running integration tests.");
-    }
-
-    const invalidEndpointMessage = "AZ_CONFIG_ENDPOINT must be an HTTPS App Configuration endpoint without a path, query, fragment, or embedded credentials.";
-    if (!URL.canParse(endpoint)) {
-        throw new Error(invalidEndpointMessage);
-    }
-
-    const url = new URL(endpoint);
-    if (url.protocol !== "https:" || url.pathname !== "/" || url.search || url.hash || url.username || url.password) {
-        throw new Error(invalidEndpointMessage);
-    }
-
-    return url.origin;
-}
-
 export async function refreshUntil(
     settings: Pick<AzureAppConfiguration, "refresh">,
     condition: () => boolean,

test/integration/json.test.ts

@@ -4,15 +4,13 @@
 import { assert } from "chai";
 import { DefaultAzureCredential } from "@azure/identity";
 import { load } from "../../src/index.js";
-import { getIntegrationTestEndpoint, IntegrationTestContext } from "./helpers.js";
+import { INTEGRATION_TEST_ENDPOINT as endpoint, IntegrationTestContext } from "./helpers.js";
 
 describe("integration: JSON", function () {
-    let endpoint: string;
     let credential: DefaultAzureCredential;
     let context: IntegrationTestContext;
 
     before(() => {
-        endpoint = getIntegrationTestEndpoint();
         credential = new DefaultAzureCredential();
     });
 

test/integration/load.test.ts

@@ -4,15 +4,13 @@
 import { assert } from "chai";
 import { DefaultAzureCredential } from "@azure/identity";
 import { load } from "../../src/index.js";
-import { getIntegrationTestEndpoint, IntegrationTestContext } from "./helpers.js";
+import { INTEGRATION_TEST_ENDPOINT as endpoint, IntegrationTestContext } from "./helpers.js";
 
 describe("integration: load", function () {
-    let endpoint: string;
     let credential: DefaultAzureCredential;
     let context: IntegrationTestContext;
 
     before(() => {
-        endpoint = getIntegrationTestEndpoint();
         credential = new DefaultAzureCredential();
     });
 

test/integration/refresh.test.ts

@@ -5,15 +5,13 @@ import { setTimeout as delay } from "node:timers/promises";
 import { assert } from "chai";
 import { DefaultAzureCredential } from "@azure/identity";
 import { load } from "../../src/index.js";
-import { createNotModifiedResponseTracker, getIntegrationTestEndpoint, IntegrationTestContext, REFRESH_INTERVAL_IN_MS, refreshUntil } from "./helpers.js";
+import { createNotModifiedResponseTracker, INTEGRATION_TEST_ENDPOINT as endpoint, IntegrationTestContext, REFRESH_INTERVAL_IN_MS, refreshUntil } from "./helpers.js";
 
 describe("integration: refresh", function () {
-    let endpoint: string;
     let credential: DefaultAzureCredential;
     let context: IntegrationTestContext;
 
     before(() => {
-        endpoint = getIntegrationTestEndpoint();
         credential = new DefaultAzureCredential();
     });
 

test/integrationHelpers.test.ts

@@ -8,49 +8,11 @@ import { AppConfigurationClient, featureFlagContentType } from "@azure/app-confi
 import { createHttpHeaders, createPipelineRequest } from "@azure/core-rest-pipeline";
 import type { PipelineRequest, PipelineResponse } from "@azure/core-rest-pipeline";
 import type { TokenCredential } from "@azure/identity";
-import { createNotModifiedResponseTracker, getIntegrationTestEndpoint, IntegrationTestContext, REFRESH_INTERVAL_IN_MS, refreshUntil } from "./integration/helpers.js";
+import { createNotModifiedResponseTracker, IntegrationTestContext, REFRESH_INTERVAL_IN_MS, refreshUntil } from "./integration/helpers.js";
 
 chai.use(chaiAsPromised);
 const assert = chai.assert;
 
-describe("integration test endpoint", function () {
-    const originalEndpoint = process.env.AZ_CONFIG_ENDPOINT;
-
-    afterEach(() => {
-        if (originalEndpoint === undefined) {
-            delete process.env.AZ_CONFIG_ENDPOINT;
-        } else {
-            process.env.AZ_CONFIG_ENDPOINT = originalEndpoint;
-        }
-    });
-
-    it("requires an explicitly configured endpoint", () => {
-        delete process.env.AZ_CONFIG_ENDPOINT;
-        assert.throws(getIntegrationTestEndpoint, /Set AZ_CONFIG_ENDPOINT/);
-    });
-
-    it("normalizes an HTTPS endpoint", () => {
-        process.env.AZ_CONFIG_ENDPOINT = " https://integration.azconfig.io/ ";
-        assert.equal(getIntegrationTestEndpoint(), "https://integration.azconfig.io");
-    });
-
-    it("rejects empty, malformed, or non-origin endpoints", () => {
-        for (const endpoint of [
-            "",
-            " ",
-            "not-a-url",
-            "http://integration.azconfig.io",
-            "https://integration.azconfig.io/kv",
-            "https://integration.azconfig.io?query=value",
-            "https://integration.azconfig.io#fragment",
-            "https://user:password@integration.azconfig.io"
-        ]) {
-            process.env.AZ_CONFIG_ENDPOINT = endpoint;
-            assert.throws(getIntegrationTestEndpoint, /AZ_CONFIG_ENDPOINT/, endpoint);
-        }
-    });
-});
-
 describe("integration test context", function () {
     const endpoint = "https://integration.azconfig.io";
     const credential: TokenCredential = {