From e3e73fd7b1de3ed57cb7d8fde4a14ee3e326d97d Mon Sep 17 00:00:00 2001 From: Rafael Vuijk Date: Wed, 4 Nov 2026 13:25:04 +0000 Subject: [PATCH] Install the GA .NET 10 SDK in CI, not the stale preview Every workflow asked setup-dotnet for '10.x' with dotnet-quality 'preview', left from before .NET 10 was released. That quality now resolves to 10.0.100-rc.2, so the SDK that builds is whichever newer one the runner image carries, and its ILCompiler is 10.0.13. GHSA-p3jp-9v83-76w9 (published 2026-11-03) covers ILCompiler < 10.0.14, and the C++ export publishes with PublishAot and treats NU1903 as an error, so the three AngouriMathCpp jobs fail at restore on every run since. The default GA quality resolves '10.x' to SDK 10.0.403, which carries 10.0.14. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/Benchmark.yml | 1 - .github/workflows/BenchmarkKeyCommits.yml | 1 - .github/workflows/CPPBuild.yml | 1 - .github/workflows/CPPTest.yml | 1 - .github/workflows/CSharpBuild.yml | 1 - .github/workflows/CSharpTest.yml | 1 - .github/workflows/EverythingBuild.yml | 1 - .github/workflows/FSharpBuild.yml | 1 - .github/workflows/FSharpTest.yml | 1 - .github/workflows/GeneratedFilesUpToDate.yml | 1 - .github/workflows/GrammarUpToDate.yml | 1 - .github/workflows/Harnesses.yml | 3 --- .github/workflows/IntegrationTest.yml | 2 -- .github/workflows/InteractiveBuild.yml | 1 - .github/workflows/InteractiveTest.yml | 1 - .github/workflows/Nuget.yml | 1 - .github/workflows/TerminalNightly.yml | 1 - .github/workflows/TrimmingAndAot.yml | 1 - 18 files changed, 21 deletions(-) diff --git a/.github/workflows/Benchmark.yml b/.github/workflows/Benchmark.yml index 572c1f5c4..09be1b4d2 100644 --- a/.github/workflows/Benchmark.yml +++ b/.github/workflows/Benchmark.yml @@ -43,7 +43,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: 'Inter version CPU benchmark' run: | diff --git a/.github/workflows/BenchmarkKeyCommits.yml b/.github/workflows/BenchmarkKeyCommits.yml index 12228f4ea..c8fe9fb0c 100644 --- a/.github/workflows/BenchmarkKeyCommits.yml +++ b/.github/workflows/BenchmarkKeyCommits.yml @@ -43,7 +43,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' # The script reports a commit that will not build rather than failing on it, so this step # succeeding means "the run completed", not "every commit was measurable". The table says diff --git a/.github/workflows/CPPBuild.yml b/.github/workflows/CPPBuild.yml index 744f8f0c6..512dfdac2 100644 --- a/.github/workflows/CPPBuild.yml +++ b/.github/workflows/CPPBuild.yml @@ -49,7 +49,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: 'Generating exports' run: | diff --git a/.github/workflows/CPPTest.yml b/.github/workflows/CPPTest.yml index 34ca00fcb..a2b3d3026 100644 --- a/.github/workflows/CPPTest.yml +++ b/.github/workflows/CPPTest.yml @@ -51,7 +51,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: 'Install some libs for Linux' if: ${{ matrix.os == 'ubuntu-latest' }} diff --git a/.github/workflows/CSharpBuild.yml b/.github/workflows/CSharpBuild.yml index 1f6f46f8d..238c3bdab 100644 --- a/.github/workflows/CSharpBuild.yml +++ b/.github/workflows/CSharpBuild.yml @@ -22,7 +22,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: Build AngouriMath run: | diff --git a/.github/workflows/CSharpTest.yml b/.github/workflows/CSharpTest.yml index 0999ccdf8..8c087929f 100644 --- a/.github/workflows/CSharpTest.yml +++ b/.github/workflows/CSharpTest.yml @@ -36,7 +36,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: Build Tests # We need it to be able to retry run: | diff --git a/.github/workflows/EverythingBuild.yml b/.github/workflows/EverythingBuild.yml index 53dc3312a..b13cd60c5 100644 --- a/.github/workflows/EverythingBuild.yml +++ b/.github/workflows/EverythingBuild.yml @@ -21,7 +21,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: Build AM run: dotnet build Sources/AngouriMath/AngouriMath.csproj diff --git a/.github/workflows/FSharpBuild.yml b/.github/workflows/FSharpBuild.yml index 1bddeecc2..7b684286d 100644 --- a/.github/workflows/FSharpBuild.yml +++ b/.github/workflows/FSharpBuild.yml @@ -25,7 +25,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: Build run: | diff --git a/.github/workflows/FSharpTest.yml b/.github/workflows/FSharpTest.yml index f1648231d..7bdbe74f0 100644 --- a/.github/workflows/FSharpTest.yml +++ b/.github/workflows/FSharpTest.yml @@ -31,7 +31,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: Build Tests # We need it to be able to retry run: | diff --git a/.github/workflows/GeneratedFilesUpToDate.yml b/.github/workflows/GeneratedFilesUpToDate.yml index 8c703ad40..19173bdd6 100644 --- a/.github/workflows/GeneratedFilesUpToDate.yml +++ b/.github/workflows/GeneratedFilesUpToDate.yml @@ -49,7 +49,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' # The one tool this needs beyond the SDK the other jobs already install. - name: 'Install the T4 processor' diff --git a/.github/workflows/GrammarUpToDate.yml b/.github/workflows/GrammarUpToDate.yml index b31465771..11eda270c 100644 --- a/.github/workflows/GrammarUpToDate.yml +++ b/.github/workflows/GrammarUpToDate.yml @@ -49,7 +49,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' # The same two commands Sources/Utils/antlr_rerun.bat runs, without its interactive pause. - name: 'Regenerate the parser from the grammar' diff --git a/.github/workflows/Harnesses.yml b/.github/workflows/Harnesses.yml index a6fa25d47..9bd6ddbf1 100644 --- a/.github/workflows/Harnesses.yml +++ b/.github/workflows/Harnesses.yml @@ -37,7 +37,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: Build run: | @@ -104,7 +103,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: Build run: dotnet build -c Release Sources/Tests/Harnesses/CrashCheck @@ -139,7 +137,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: Build run: dotnet build -c Release Sources/Tests/Harnesses/DocSamples diff --git a/.github/workflows/IntegrationTest.yml b/.github/workflows/IntegrationTest.yml index cfa5fbf48..0681e171f 100644 --- a/.github/workflows/IntegrationTest.yml +++ b/.github/workflows/IntegrationTest.yml @@ -23,7 +23,6 @@ jobs: - uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: 'Pack AngouriMath' run: | @@ -65,7 +64,6 @@ jobs: - uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: 'Pack AngouriMath' run: | diff --git a/.github/workflows/InteractiveBuild.yml b/.github/workflows/InteractiveBuild.yml index 2b9ed9e5e..575b83f73 100644 --- a/.github/workflows/InteractiveBuild.yml +++ b/.github/workflows/InteractiveBuild.yml @@ -25,7 +25,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: Build run: | diff --git a/.github/workflows/InteractiveTest.yml b/.github/workflows/InteractiveTest.yml index da555bf5f..baf505480 100644 --- a/.github/workflows/InteractiveTest.yml +++ b/.github/workflows/InteractiveTest.yml @@ -31,7 +31,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - name: Build Tests # We need it to be able to retry run: | diff --git a/.github/workflows/Nuget.yml b/.github/workflows/Nuget.yml index 4138de1db..13782a473 100644 --- a/.github/workflows/Nuget.yml +++ b/.github/workflows/Nuget.yml @@ -14,7 +14,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' - uses: actions/checkout@v6 diff --git a/.github/workflows/TerminalNightly.yml b/.github/workflows/TerminalNightly.yml index c65fc7a67..b93d53a80 100644 --- a/.github/workflows/TerminalNightly.yml +++ b/.github/workflows/TerminalNightly.yml @@ -49,7 +49,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' # The release's tag without its 'v', as Nuget.yml reads it, so that the Terminal is released # under the packages' version; by hand, the version asked for; for a pull request, 0.0.0. diff --git a/.github/workflows/TrimmingAndAot.yml b/.github/workflows/TrimmingAndAot.yml index 618e7af4a..9ecce3a1b 100644 --- a/.github/workflows/TrimmingAndAot.yml +++ b/.github/workflows/TrimmingAndAot.yml @@ -36,7 +36,6 @@ jobs: uses: actions/setup-dotnet@v5 with: dotnet-version: '10.x' - dotnet-quality: 'preview' # ILC links the runtime into the binary and needs a native linker and zlib to do it. - name: 'Install the native toolchain for Linux'