From 570f62670259201748a7a3a16286d9944a52048d Mon Sep 17 00:00:00 2001 From: James Rosewell Date: Wed, 11 Nov 2026 22:57:42 +0000 Subject: [PATCH] Name the data update logging test's key so it is not an old variable name The environment variable names check fails on rc at line 76 of DataUpdateServiceLoggingTests.java, where the constant LICENSE_KEY starts a wrapped line and so matches the check's start of line form for an old name. The constant holds a made up licence key for the test rather than naming an environment variable, so it becomes FULL_KEY, beside MASKED_KEY, and the test reads the same. --- .../engines/services/DataUpdateServiceLoggingTests.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pipeline/pipeline.engines/src/test/java/fiftyone/pipeline/engines/services/DataUpdateServiceLoggingTests.java b/pipeline/pipeline.engines/src/test/java/fiftyone/pipeline/engines/services/DataUpdateServiceLoggingTests.java index 4ec40a1b..15a2f9a1 100644 --- a/pipeline/pipeline.engines/src/test/java/fiftyone/pipeline/engines/services/DataUpdateServiceLoggingTests.java +++ b/pipeline/pipeline.engines/src/test/java/fiftyone/pipeline/engines/services/DataUpdateServiceLoggingTests.java @@ -70,10 +70,10 @@ public class DataUpdateServiceLoggingTests { // 13 September 2020, 12:26:40 UTC. private static final long FILE_MODIFIED_MILLIS = 1600000000000L; // A license key of the length and characters the Distributor issues. - private static final String LICENSE_KEY = "QF8ZR2KD7NMB4XWT9HJC3LPA"; + private static final String FULL_KEY = "QF8ZR2KD7NMB4XWT9HJC3LPA"; private static final String MASKED_KEY = "********************3LPA"; private static final String KEYED_URL = UPDATE_URL + "?LicenseKeys=" + - LICENSE_KEY + "&Download=True&Type=HashV41"; + FULL_KEY + "&Download=True&Type=HashV41"; private static final String MASKED_URL = UPDATE_URL + "?LicenseKeys=" + MASKED_KEY + "&Download=True&Type=HashV41"; @@ -430,7 +430,7 @@ private AspectEngineDataFileDefault newKeyedDataFile(boolean inMemory) { AspectEngineDataFileDefault file = newDataFile(inMemory, false, false); DataFileConfiguration config = file.getConfiguration(); config.setDataUpdateLicenseKeys( - Collections.singletonList(LICENSE_KEY)); + Collections.singletonList(FULL_KEY)); config.setUrlFormatter(dataFile -> KEYED_URL); return file; } @@ -449,7 +449,7 @@ private void assertKeyOnlyMasked() { } assertFalse( "The license key is in full in: " + text, - text.contains(LICENSE_KEY)); + text.contains(FULL_KEY)); } }