Skip to content

git hash reported over the wire by API is from the diem library #415

Description

@dboreham

If you query a node's API service you get some useful information like this:

$ curl -s http://localhost:8080/v1  | jq
{
  "chain_id": 1,
  "epoch": "406",
  "ledger_version": "141782488",
  "oldest_ledger_version": "0",
  "ledger_timestamp": "1748439929040214",
  "node_role": "validator",
  "oldest_block_height": "0",
  "block_height": "70861200",
  "git_hash": "750f39b5b91114754203d858ec6a758b2f664084"
}

But it turns out the git_hash field is not reporting the git commit SHA for the libra project itself. Instead it's reporting the commit SHA for the diem library. In itself probably not an un-useful thing, but it would be good if
both were reported, or just the libra project hash since the diem version can be inferred from that via Cargo.lock.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions